mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Kukjin Kim'" <kgene.kim@samsung.com>,
	"'Doug Anderson'" <dianders@chromium.org>
Cc: "'Jongpill Lee'" <boyko.lee@samsung.com>,
	"'Jaecheol Lee'" <jc.lee@samsung.com>,
	"'Thomas Abraham'" <thomas.ab@samsung.com>,
	"'Olof Johansson'" <olof@lixom.net>,
	"'Jonathan Kliegman'" <kliegs@chromium.org>,
	"'Michael Spang'" <spang@chromium.org>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	"'Russell King'" <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work
Date: Wed, 03 Apr 2013 11:16:37 +0900	[thread overview]
Message-ID: <24b501ce3011$454d3c70$cfe7b550$%kim@samsung.com> (raw)
In-Reply-To: <24b401ce300f$5a767b40$0f6371c0$%kim@samsung.com>

Kukjin Kim wrote:
> 
> Doug Anderson wrote:
> >
> > to make suspend/resume reliable on the ARM Chromebook
> > (exynos5250-snow).
> >
> > A few more details:
> > - The first patch is not strictly needed but was a nice cleanup.  Our
> >   understanding was that EINT0 was originally turned on for exynos
> >   evt0 silicon and not needed for evt1.
> 
> Looks good to me, applied, thanks.
> 
> > - The second patch is more important and (also) more obvious.  The
> >   function was modifying the S5P_WAKEUP_MASK register and then
> >   clobbering its own modifications.
> >
> Applied with 1st one, BTW, do you want to send this for stable tree?
> 
One more note, just now I discussed Jaecheol Lee about the bit,
ENABLE_WAKEUP_SW, as the patch fixed, it should be cleared but used to be
set s3c_irqwake_intmask. Let me check again, then if any updates I'll let
you know.

Thanks.

- Kukjin


  reply	other threads:[~2013-04-03  2:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 16:51 Doug Anderson
2013-03-19 16:51 ` [PATCH 1/2] arm: exynos: Remove hardcode wakeup unmask for EINT_0 Doug Anderson
2013-03-19 16:51 ` [PATCH 2/2] arm: exynos: Clear ENABLE_WAKEUP_SW bit when entering suspend Doug Anderson
2013-04-03  2:02 ` [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work Kukjin Kim
2013-04-03  2:16   ` Kukjin Kim [this message]
2013-04-03 17:20     ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='24b501ce3011$454d3c70$cfe7b550$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=boyko.lee@samsung.com \
    --cc=dianders@chromium.org \
    --cc=jc.lee@samsung.com \
    --cc=kliegs@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=spang@chromium.org \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®