From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E8C36165F for ; Thu, 20 Aug 2026 14:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787236835; cv=none; b=JMQ0n8odmHRn/qND8wEfWAwEj64/Si1KeTwgM977kvWM+stJYaDfYwffoHkgHd5TvjIY6zeaGlURnCYdBQzdUeiTimvAueuuMyvMJ4tRdPtAcuJLMXak2sqpv428+elLCgZ9kJHjFrb2Fw22vaJYFGgJKUHrARzDyVHYJzBfBPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787236835; c=relaxed/simple; bh=Ch0bNTUrZrdhGWjR+v/vzmIz0s6OQlTQ1MsLie08Hls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oc17f4vBJ5Lmi/bysg3XtJlFtThEOj3c4FtZSmzTpRctkkS6R39r00WX2JSpkq1OkK1AmC+Srj6y72gOTVSDwx1mxtUWWDtBFj8ov+O9h+fyoqTTifrvWflVur2vEatmk1aHe8tIELCyYdQCz45ssQwPoMO7BmO4ss0R0oT4VQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kPH/9l1m; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i+Ykh1gE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kPH/9l1m"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i+Ykh1gE" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67KE8IXs3146855 for ; Thu, 20 Aug 2026 14:40:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bULlRsmm21KR6nA5VCIlR2YU5yJGOIf9AWnYowD50+A=; b=kPH/9l1mFLZiX2zr TObXnAxpjIee6cv16jNerUkFWh+5Lj0neZEOTLePNk3YvmX0NYL+mmXoGVBiz2EG iAnEI6Y0ZYjqkoeMsUF2lgRsLS8AfFBgJ7hcPHnXZCsODBXFHKvyKUO5wr0obYOy W97g+AjwZWNo7T2zdAQf37uTrrzamFpA1WmbKAvmSh9GZ0wseELGicWcaxRfeQZm SfjlgFxLEYCGU8i4asgsuJ2kAh7V3tNeRQuUbUW0RK/vA1SzXq7mFbRkMtAwjrON 2LJjCToeg5/FqNYEGkHFkTAQAsCYWD9nx1pdj9+Rp2kj2NHvxIeZKp/43gefo6VI Syl+Ig== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5vh7sutt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 14:40:33 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-97c46be4adaso7926241.1 for ; Thu, 20 Aug 2026 07:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787236832; x=1787841632; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bULlRsmm21KR6nA5VCIlR2YU5yJGOIf9AWnYowD50+A=; b=i+Ykh1gELlgqjFmD+T75hMNrhhrKyU2cDjla5wUcGW9eGrYuZkQWsRVqryzzh7Mo9W jEPto22SbG+BLJS+Y/B0BVYX4niM1PGv8aySkptNj+CLl4HUsqmMWgMCncJLAcRpLEm+ cU4wPRXcFY9KSfH7pvZZkgKYrYo0G08hvwd8OlmGcKZSCSYSPAkeOf1x1y3K7gn5eZRn oV4u6knRjlM1wZ5n9gpY6k9gEOoaDMLgYZs4B3QmS4dUBta+ZtJxgTXHJH8MK5NvfXO8 XrdN2RWo07g/caT1ywCUDnCxFNUGazs7t1S7CTzpkv2JAv0Bmf7/BlWKsuqY2ZOevjPF ZVDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787236832; x=1787841632; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bULlRsmm21KR6nA5VCIlR2YU5yJGOIf9AWnYowD50+A=; b=KnQsW5FFZP8JTNulx7Ta2qepBeP13OxdRcLe6c8XLqUT9F+eixIaVedlCbmMtlYg6G vZI3jnhad3s/Cf3NsCpOvBB23OxiFgSbdAnhayqE0giSjAjEZf2ImelpN5srxrK7u8ix PHDkFfmsmcWggHEpttna+ZujYkeOVWdUleHyfFgUOFFmNEdSXtnvA+ivBEC3vyptvD0M g+TupnP1PZ61wRGoGVN3OaU7sjfE7qfPvho7Q2zGW/Ks1XaUpbT4ylhNnGAanPyKFl45 6l8ESNdJz/trBlAQvQXBm4js3bVvrvqc8RcRQcgR6tAgUpgTLpgEG48YcJIUd2r6vC2W xHUw== X-Forwarded-Encrypted: i=1; AHgh+Rqpag87BrhaWB8ONBIBtN2Rtro8esPEOVMOKvdjYzXG1kgKEgBK00SPTIvEhDgO+anp/L5N7jBqC5LT1b4=@vger.kernel.org X-Gm-Message-State: AOJu0YzbXWW3hI1qJFPBiRUXRvVOKz0iRR138y2RFeIiDBwgvGE1WSmr y+Jevh9/oiE9AafcxsvNdJJtnLrasl+qxrfbDoflq5WWVenjYo3yp+QoOrcGHspAEGB1oCFUnwu RYEUrKo4NAtGotwQ5uEf8RSTOOVkcHAJlnH2F2JsYYlbSDFSfOpTY1MiuWDxV2GBOIQk= X-Gm-Gg: AR+sD12ZR/cL7GDZNKjxJA7m9dpxUn0jbUVQTKhbmhOt0lwkwm9rUqUpvS2eVI4A9IM 3Sp9C4pGig4D/0L2O/LVu89mLPLuHr+k38JpVPHwY1CVc3kbiIIu/GCS4lFRs1pos4r2c8L5FW6 dXybqf/bCql0af9wrTzSODkehQU1qmZdadX4Xhlv7lm5NAbl1RC9mWAb970JQZV8NfGhNOAJio0 SAXHyvY72Mrefz5NzPal+qSGpIRJSpUENb6GMZSRA7FPImmXURKWo7VIp1u9uvsd1sJbYYOLkY5 dXBYHgQIpuwRKA+ANXIP8x2T/471zwUxgBXskI2Wpk84EwhYPAalxovax+GuOKRaUAcYfA/lf3V OU1pd1u/6jKKbTK8q+0Y2vtdm X-Received: by 2002:a05:6102:14a8:b0:778:9d46:6dbf with SMTP id ada2fe7eead31-7789d46e53cmr1458796137.1.1787236832112; Thu, 20 Aug 2026 07:40:32 -0700 (PDT) X-Received: by 2002:a05:6102:14a8:b0:778:9d46:6dbf with SMTP id ada2fe7eead31-7789d46e53cmr1458778137.1.1787236831752; Thu, 20 Aug 2026 07:40:31 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b478860c85sm1333752e87.35.2026.08.20.07.40.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 07:40:30 -0700 (PDT) Message-ID: <24b878e2-6073-491b-a454-efbd6c21e89f@oss.qualcomm.com> Date: Thu, 20 Aug 2026 16:40:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] soc: qcom: geni-se: Fix endian conversion for serial_protocol comparison To: Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260820-fix-write-to-read-only-firmware-buffer-v2-0-7badcdc455fe@oss.qualcomm.com> <20260820-fix-write-to-read-only-firmware-buffer-v2-1-7badcdc455fe@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260820-fix-write-to-read-only-firmware-buffer-v2-1-7badcdc455fe@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDEwOSBTYWx0ZWRfX39V4Qc54gQXm T5ImhSnVpmBxItsOO2RRemahI79E6swVenPuki4LZnSq+dUgD68vG1A0rQzitoZd6VzkeroLuzc 5d4KSDgg6zAyJkukzFV7U35ZIENyUhQUVmEXv6eOXCIWb/gTB6GPsCmTnP34Cye6ggZOphPl+P3 TT3WrOdB6agZUeIO1ZZAT7Ac+V8q/EvhIiAzD7enMxcJLUSrySvlRXhPVus/tLdbqGMNSZSJjgU 95LeYkBhTNLJaZJp6U3pT0DTSaxUbwzo0s5YGqdvkZyQ/bB9y/ZiDOh79qZSxBFkILPQqf3jE92 Z8jdpVobVr//x9/806e/raip8lg9HbJqsd/dT+0fY8nGU+YPtzq93D1qIPZTzMETnQ3wDHxNT+7 0asbjAu7kfGVr0cxcOiUCbJSSpYnqDgMwv1dAO0Purs7DFijBMgErEMNxyb4VxyENgRFhc5EXr6 TzbAGu+AIFeMXHMfvMw== X-Proofpoint-ORIG-GUID: FW5ca_F_qze5J8ForLpLYqcP_NOtbq3o X-Authority-Analysis: v=2.4 cv=Y7fIdBeN c=1 sm=1 tr=0 ts=6a8711e1 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=iJG6fKeWqX_QHOf8h_cA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDEwOSBTYWx0ZWRfXyxKCWoTX1VVm PVY69ng12fj0F6b3ELC3k9XOkaTVlvDbSrv/hicgz3lwzCvK0mW9sxwWXajWy6TvJWFbUnZKqGK JR6saYnnCZJSbUEpS51k4rf1rT59LAM= X-Proofpoint-GUID: FW5ca_F_qze5J8ForLpLYqcP_NOtbq3o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 clxscore=1015 malwarescore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200109 On 8/20/26 4:30 PM, Viken Dadhaniya wrote: > serial_protocol is declared as __le16 in struct se_fw_hdr, but was > decoded with le32_to_cpu(). On big-endian systems the extra byte swap > causes the field to always compare unequal to the protocol argument, > so no firmware segment is ever selected. > > Use le16_to_cpu() to match the field width. > > Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem") > Cc: stable@vger.kernel.org > Signed-off-by: Viken Dadhaniya > --- Reviewed-by: Konrad Dybcio Konrad