From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3667EC4338F for ; Sun, 15 Aug 2021 00:47:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F9EB60F51 for ; Sun, 15 Aug 2021 00:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234577AbhHOAr5 (ORCPT ); Sat, 14 Aug 2021 20:47:57 -0400 Received: from smtprelay0195.hostedemail.com ([216.40.44.195]:44450 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229453AbhHOAry (ORCPT ); Sat, 14 Aug 2021 20:47:54 -0400 Received: from omf16.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 3CD741A4D7; Sun, 15 Aug 2021 00:47:24 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA id 3E1512550F6; Sun, 15 Aug 2021 00:47:23 +0000 (UTC) Message-ID: <24b9996f43b0cb012022e8dacc6ab2902f7df981.camel@perches.com> Subject: Re: [PATCH] checkpatch: fix an issue regarding the git commit description style test From: Joe Perches To: Lukas Bulwahn , Hamza Mahfooz Cc: Linux Kernel Mailing List , Andy Whitcroft , Dwaipayan Ray Date: Sat, 14 Aug 2021 17:47:20 -0700 In-Reply-To: References: <20210714082608.28918-1-someguy@effective-light.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: hg5ah11uw11epnat7cb78q49qmxgt3te X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 3E1512550F6 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19y4QaeyBAkRLoaDFg5bnTxGJV4gKEfoyo= X-HE-Tag: 1628988443-155006 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-08-14 at 10:43 +0200, Lukas Bulwahn wrote: > On Wed, Jul 14, 2021 at 10:26 AM Hamza Mahfooz > wrote: > > > > If we consider the output of the following command: > > > > $ git shortlog | grep '"' | wc -l > > 14185 > > > > It becomes apparent that quite a number of commits have titles that, > > contain at least one quotation mark and if you attempt to refer to those > > commits in a new patch, checkpatch throws a false positive. This is > > because, checkpatch disallows the use of quotation marks in commit titles, > > only when referring to those commits in commit descriptions. > > > > Joe will certainly have the final say on this. I did suggest a patch. https://lore.kernel.org/lkml/7f55d9d0369f1ea840fab83eeb77f9f3601fee41.camel@perches.com/