From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48476405C48
	for <linux-kernel@vger.kernel.org>; Fri,  2 Oct 2026 19:30:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1790969453; cv=none; b=Ey/eC0ZPY1ZzcWEtpyBuj6BX2qcfkLj6Ize0aZOYjatXRhtQL4kE3II+yWmda3ToYp1SyeqR4O11OFgUj49ptVn8Nu5ZnkGjaM/VumDccTMLCF9N6/L/DKj+YYLat12H/w5UN/sKigApUN0hwPrLTpxV+SqSjwBDMhkuJG1Ey7Q=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1790969453; c=relaxed/simple;
	bh=DWdY4n+wTpD2bTff+prcl6yAWKqUK3YmLIlkTvVSLak=;
	h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References; b=XJINpHWTwbFDgTSTtqw4TvDMLmRyXAleQQ+q2OsZaqXR4YKxn+/y0Rn5vnGWD5YmmJAOJrGNSHZGf/QCwmr9zcGpoxFyFJpGnJzj9SYplgoLslCMeVSIp6Bs8gey47v4mk1JPR5zLcxMMne5nYtYCGnZvaKkBkagRptgpXC9loM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n3NL5xFw; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n3NL5xFw"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C10E1F000FF;
	Fri,  2 Oct 2026 19:30:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1790969451;
	bh=J8mM4qitVdSD3LXu+ZiZEVubQ7QVZWIFirCQYWVxbPA=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=n3NL5xFw6Kd9dUEDQ05hV6EoETKNeOpu9ZGXDms3BqHupfDSlAiFNpjf9rMh/8E+6
	 cKzZf8ajdWYRh+4fx4BRzniTDO3MA7iWenW25BIIW94wQQ0YcKIHY3ntle17xM/+Fc
	 nAtQhVwhap3sAdwiT486CsZS3OwC81dxA4BhNbeHgcnJ6ckaHFAu9828hBZXSJCx/r
	 SNqVki6VsPE3t+11cTqO6De4WNSA90Fcm3GekAF/I+dvoug8eBCxxqAKneQSO5bfH3
	 h7uSwZS9T3B8sqn71ttTS8D5mHFuVqa8V4Wtki9vCFarRrG/Y7s2jD07qcOP/mUBnK
	 IjNTuXG0VmMvA==
Date: Fri, 02 Oct 2026 09:30:50 -1000
Message-ID: <24bf5dfc5777aaa0b18a6778437eca21@kernel.org>
From: Tejun Heo <tj@kernel.org>
To: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	kernel-dev@igalia.com, Boris Brezillon <boris.brezillon@collabora.com>,
	Bradley Morgan <include@grrlz.net>, Chia-I Wu <olv@google.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Matthew Brost <matthew.brost@intel.com>,
	Steven Price <steven.price@arm.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>, Breno Leitao <leitao@debian.org>
Subject: Re: [RFC v6 1/3] workqueue: Simplify unbound sysfs attribute
 registration
In-Reply-To: <20261001160711.59888-2-tvrtko.ursulin@igalia.com>
References: <20261001160711.59888-1-tvrtko.ursulin@igalia.com>
	<20261001160711.59888-2-tvrtko.ursulin@igalia.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>

Hello,

The following is a Claude-generated review.

On Thu, Oct 01, 2026 at 05:07:09PM +0100, Tvrtko Ursulin wrote:
> +static umode_t wq_sysfs_unbound_group_visible(struct kobject *kobj,
> +					      struct attribute *attr, int n)
> +{
> +	struct device *dev = kobj_to_dev(kobj);
> +	struct workqueue_struct *wq = dev_to_wq(dev);
> +
> +	if (!(wq->flags & WQ_UNBOUND))
> +		return SYSFS_GROUP_INVISIBLE;

SYSFS_GROUP_INVISIBLE is documented for named groups only. For an unnamed
group, fs/sysfs/group.c masks the bit off and the leftover 0 is what hides
the attribute. Can you return 0 here like wq_sysfs_is_visible() does?

Thanks.

--
tejun