mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>,
	Thorsten Leemhuis <linux@leemhuis.info>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] docs: verify/bisect: fix typos, formating and punctuation
Date: Thu, 3 Sep 2026 22:34:41 -0700	[thread overview]
Message-ID: <24c2aa21-d491-4ee2-9d53-de593353f2cc@infradead.org> (raw)
In-Reply-To: <6ba88e25314a5818f8fb31dc3a2165f6786e890d.camel@mailbox.org>



On 9/3/26 10:18 PM, Manuel Ebner wrote:
> On Thu, 2026-09-03 at 09:59 -0700, Randy Dunlap wrote:
>> Hi Manual,
>>
>> On 9/3/26 8:43 AM, Manuel Ebner wrote:
>>> Improve readability.
>>>
>>> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
>>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>>
>> It looks like you might be misusing the Reviewed-by: tag here.
>> My only reply (to v1 of this patch) was:
>>   https://lore.kernel.org/linux-doc/0475c09c-e165-41a5-b654-5c6aefeaab0b@infradead.org/
> 
> My thought process was: when I include all you suggestions and your message ends with
>> All of the other changes LGTM.
> 
> you are good with the result. Thus Reviewed.

I understand, but still, it should be explicit (or you could ask).

> I probably did this a couple more times with you and others.
> 
> I'm sorry and I'll pay more attention to this.
> 
>> and in that email I did not write "Reviewed-by: /me".
>> Just because I commented on it does not mean that it merits
>> a Reviewed-by: tag.
>> I.e., a Reviewed-by: tag must be explicitly written by the reviewer
>> for it to be included in a patch.
>>
>> Please see Documentation/process/submitting-patches.rst for more info,
> 
> I'll reread it.

Thanks.
-- 
~Randy


  reply	other threads:[~2026-09-04  5:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 15:43 Manuel Ebner
2026-09-03 16:59 ` Randy Dunlap
2026-09-04  5:18   ` Manuel Ebner
2026-09-04  5:34     ` Randy Dunlap [this message]
2026-09-04 13:59     ` Jonathan Corbet
2026-09-04 14:53       ` Manuel Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24c2aa21-d491-4ee2-9d53-de593353f2cc@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=manuelebnerli@mailbox.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®