From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B925C1773A for ; Wed, 1 Jan 2025 15:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735744809; cv=none; b=q5V7XsqFw6avR8c1tTomW7pwa24PhKdbwCTbueoTRFI0zG1Ajud/Zw8MHQ6woLm9WpMhHjFzohptEE8yweMrhkH4jo2BpNmR+MeBWHLqRXp20ALwjqKVq+upxGwGITPL81QdgrM1pCZFnyzN3e+MoJmsbYm5i2cD8/Upq8F+O5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735744809; c=relaxed/simple; bh=eBSv8D38HRXjC0QqvN2V786zPPTBJPZfLcFuERdhM8Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z1WJEWqGZbplLAqsH3etBNq/x6O5vs0JvxAOUsnFSfAwRqnoDJdqXfwg/l6Ss4irJS6iIthpJW4wn2KOXauChI7ZLD/M/vBMVvznBYaigIETp0Qd1CVsdEOw3n/f8BsusuDijIQC0xYzGCdocOJOPCld1kZF/7D+MUpLG6W6OIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZWf1GJpZ; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZWf1GJpZ" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5d3d143376dso15439700a12.3 for ; Wed, 01 Jan 2025 07:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735744806; x=1736349606; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=S/myDh+TmQLAgENNyjhGRDFzIXNAWZBQN8/oinLahgQ=; b=ZWf1GJpZP0yp0BTPorQ9xOg46qQCw+Dx7uycOV9yuFQXu/qWkgbqKUj1BKSZiiRKL1 sCSmY/OG4ppdv/gaf6h79gM9kR9wJFOvBmB49+SkEM4N2kNtG7DuKETB20IPD699MaXc Q+/3zfW92MopnqKBX4BJRrn8dmzX5sH9mXtADFhGJFf+g72vHoS5xi8hv543VWXHzS4+ vaOPXF9uPMqR4rCSgFUGqhla+oUF9IiBpTZCtzgiihZT0DCRlva1shatdqUQzgzb+2N1 bsJtFu99aMhwrNsV5Jcj6qAHnE9X5vgncisdsCF8DpUGPFbym/yxAy4tnJcBm615dkYW jwLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735744806; x=1736349606; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S/myDh+TmQLAgENNyjhGRDFzIXNAWZBQN8/oinLahgQ=; b=DdKMiC6ey0M2JbhZr0dWpUBSURY0mXtz8NqkwBCQ56qPSwIRbqLm3bNgLf0+M8vqeV XBFQGB5NXKDAZpjULzTtQ9aWfy4pxIGbDLH7xtoZjXlHPvpXnayFDMQrjFnBN775f6Gf Fut7lUAXwIpqi/Ty2uqX6psotm4L2NdRHcPCWOSMFuVtIeOPTz94KxjeHyFBySDuBpXx aSk91+g7sRD8nnJSVnhYSWZ/nvYrPX9p2qndfFaz6q+AkRZrJvYxPELnPKGTD5fwk7qS Y128kHGUXvpHvjYAx3/ZsFSvbI1RIp11tKY80eZKJBMbCQuv1Bd9awN6K4RUzp5mybfw LzHA== X-Forwarded-Encrypted: i=1; AJvYcCVSNxrB7ugXW9dAVSYWATu5iO0SnyVlochRWoA58RuT2wv93s/Kxq74Qp8rWOMN4tY4209STjX2WXT18Dc=@vger.kernel.org X-Gm-Message-State: AOJu0YzEepm85sDpy5Dr1JtmJPSab8KITC40fOCfclxxJauRwA7QR84M BwLl+8yqT9VL+v8HDoX9G9hmSTmocX/rhGEFHhu+uckMn0tVdbGo X-Gm-Gg: ASbGncs4Qlt8R04w4a4+CU8VQu19jMw2EzcInchKEHK4+Szcz2HBYtk+tMDw6E/U3/7 57HTQW6+1y3HfXhOIvENEMfyTodzizplnMcBXFWWan3vz5UbL6FVA9tPlmArKMHeRSsezDvaBvV rtombVsiHzGyLUVfiYQD4FuJCrNzmkMXncGrnQy+tDPKKngKzOyqqSDFsLy+PKiyD7E3et40RzU 3PJzihA+wru/eu4OXiwBcb3grksCUAm8Skrda1Az/8lyRMgvu48Aka5sdY222VGzwemhWe5 X-Google-Smtp-Source: AGHT+IGECEMAOda7kRcXPz4TemxgaiAtaNt1hi7wmNXw57CgHZNGtBAmGJHwfcevgCm2sR/twmh2Wg== X-Received: by 2002:a05:6402:35d5:b0:5d0:e877:7664 with SMTP id 4fb4d7f45d1cf-5d81ddada54mr39252504a12.19.1735744805753; Wed, 01 Jan 2025 07:20:05 -0800 (PST) Received: from [132.69.243.32] ([132.69.243.32]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80679efc9sm17158529a12.47.2025.01.01.07.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2025 07:20:04 -0800 (PST) Message-ID: <24c9b4b6-e07b-4cee-aa7f-6f317a1b7ef6@gmail.com> Date: Wed, 1 Jan 2025 17:20:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes To: Rik van Riel Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-10-riel@surriel.com> <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com> Content-Language: en-US From: Nadav Amit Autocrypt: addr=nadav.amit@gmail.com; keydata= xsFNBF3nSCQBEACinGNWCLb3Iptvg066zPUQCFfR0nIX+j/pjxlLd094zOKLJ7Z1wKNNTQgb +Y1GQYwKurK1hFHISPc1T7xk2twzov5niFqQp1/E0I6t/92rxo7C26tKMrCHgqXpFXXBaOvq t0QN8B83o3sfS3OZyc0F5hWoJijhKQ+h7dJHMPpBBeTWiZzYVlMNz/wRzYrh1nvesbGJtV1w Wk96qoQAOagczRaSRWouJ1O2JbHqQarLJG657hqtPZctQ1mkXQcJedT1c8ejWBdIiU0rIpV/ R2uTgM5NSjVrY5OxiS2G4C/bDcI4Q6ApWxqu1zRGffKWRFJdQvttSv+JbW2q6OCvJReJs1i6 nTovpfJb3g9d7U76LtAw7HE5iIl5CmyFoTMMH+sDc5PG7JRboiofku9DWeDGK4rB2s97GuA9 BXJDHBbH1AI+Y0H6oz/Dri1sQSayUU8Xj/jCkwxpwDle1qYYE0UM4PqDTUoeejURR/h/AREt bCecfxNUYNz2jY8PUL0YXj6yex2p1otMy5sy7djrTqhC02AXLQ3Oab2UJuMZnf4cTbN2sGXu CRXcCSsoyhxIFtwpgdVIDqkPMCOEPvUwy9hWs0N9Xy+jOebpH6FYxq83pP3IhyBdaoexoyGL IkSzrO4+0bVk5voh5SIYVkLEooMSEQT9rfSdrJmRRuM7S/PowwARAQABzSFOYWRhdiBBbWl0 IDxuYWRhdi5hbWl0QGdtYWlsLmNvbT7CwZcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQRIkveiyXlibH/D0jUdoCpJptoPWgUCZWMLXAUJCz4qOAAKCRAdoCpJptoP WoWjD/0d8I+qQIHp2Eq7Whi+idkGDJaaBksRw2r0+XTzRj0CsCFJS7oMWudQaYaI2bTW9uha zfcmpnkm5aOVoxGOGJUJSy0H4of6lShE+7caoz1pdX+y15STij3+RvUjcGn0N+Mpxrnj6anm ArH5KOwzQJDiMF48ntQ2EQAFJ5X6YZ6Ed9N4I88XPeOtWaU21Q5tZI/ASHrQTH7BMukkVe2U PkSjn205vbrCfcC4Ohu9HXC8ey6l5txomFaTIRvaz1La3W8gQHhT2D2QeNnJFRudN5hQJNIE OHFi6QmPVIbI/uYD82h5uesiufycV2kvuIACmvs2T3tpaxSY9HOJF/yAhqg28hKE4wKQIwh2 wzZ+ywDeZ5TboqTjTU9oPHuRTxYItWmevJgQDwOYcssYI4wOdXvu/bh5VvhBgJxgkOOH7j8N efzqooL/2/pD/1JAO9GjPEWbuRx0dZh5tcMq/RYFFhdZQNFYmqdDyY0+y6ntxEo25ScvVLfR GqhpyJkN9+cqJZfg3IolbWoZxkSLtiCBge/EDRRoLJpjpsLpBmMmQcH/50WgQcoL5ObVlc1I ft1sKfzZvIyqXZfu3YcWgvOXfVXaMw1dXQ8ffwgyCSIsKvA5+Y45knd72SHny5z3gi1YsMc1 lm24v+OfxfmZMmJQ7TXBDl0JkOMnQ3A+KDb0oGAI6c7BTQRd50gkARAAt/NqfDSMph828JIn VOck27zsyT12AHRLIhsCCatw+zYbdMSLTW6hd/sChStdndAQlqOOW3mpm6bA+jl59c4OhkBW 8fDKgaWjVq8kBm4Z61zhzk3oXMmxgQ3cqMEfN36PCpcfs5MtLiMoa2JxaqFMQbKkmcZqz8fw qGIID/SMI5qdk+yWZSmR+6RdzXfppEIeqs78qTFxaEl+0MlAcgo2AjrMPLIjNK3k4jNAVCix KjMfkkPk6xVmP5Q7cr1st0xTTa1APt0y966oa6CZIdHY76D/jLpjJlfalctmEAxmyBqK0ZkK WDkEF+qCqqZ7oSkC1Q0ogBuBffIZb5srleqMz++IutiE4r/LELs7RanXXCRK5JYzZc/uAnxN fCJzqKR5/JxoSnCh0yQNU4FHa78DeD/SLnCu8JwTGkcX9ZUW/ZQ+5Nsimy+SlZb0UyaWA+vr Q7+F7OAL6PFsE8v+Q2u2EHwa8e2KmsL0sC+enBXbaogLFFfKi4I13vOk+76nCZTNetRhAubM etLe1PZZ0IDzgGhjFg+cc/jptq3qYjK+3jzhdKaqmoibAoea3E/5HsTVVbxUiYEdk2crTqf9 Mr5S5AzQfH19xU7uUduBvjN3L0dRKP0wJEqgCIB5gZBjD8AYmKSgdEujDAPQNXTJgwB99C+r F0XoHEmO6m9vI6djzDsAEQEAAcLBfAQYAQgAJgIbDBYhBEiS96LJeWJsf8PSNR2gKkmm2g9a BQJlYwtcBQkLPio4AAoJEB2gKkmm2g9ah7wP/jP18+dznONUt3Nga6XKYxxlVmVnMlqHx6SB jDWTwFzcQ6UeVVUmODWBSLI+iqg5djkgsTcHwI668qhIyyWaXC9ld+ONhUaE4NH1PKcJ8cdG vzhdTG8lM9mwmnJriTfih59OLI2yKpml/et44gvsfQpmFOyrdH9u6xPai5h3KyOoXD+Q3EzQ KEiHqs2x0PX72Jz4iVKEanP+qxEwzarUUcum94ecGilYY4jfxhfkgwBWjmC7ExbVTSEKIx3Q zdDbDiAxhAWymSisP3lbYqRo8mkg8r2emNan5L5Xh1b/62zmMO+p6gzucV7vO0VJxlKuUkFW 77Ug+X+hkDedvp2oRBz+wKtBxwSxlTM4toD49Jn111OMS6R5opquZP+/SJH1njSKY9MY3D3D 57QDpRUvqbqMDdqZqmYlMxntxTJ+0yksR61/t62F/bSp4XLxbgwCXMm73TxGrU73ngaS/Nxz Pv28VEcCGXZqFS2sbsbBSEjGgPhXf73YlI1fYiAFiaKHKvlofX+xNLeRHr9/+fL4JWPFurGi WYMyVA5Fv1sfefXhdEv9qNlhyNHxxB3vEpxkEOdo0JUhNfIcxe/w5iOfCUAtwUfvijvHUFHh U5QeQckJZTApjJ4S/Wa1ef8eS/LBsvG9xMNG3Ns+M+xR6unu6gTuzUNp7Zsxgmp8hs0racLB In-Reply-To: <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/01/2025 6:42, Rik van Riel wrote: > Fixed for the next version. Thanks Rik, Admittedly, I don't feel great about my overall last review - it mostly focused on style and common BKMs. I still don't quite get the entire logic. To name one thing that I don't understand: why do we need broadcast_asid_list and the complicated games of syncing it with broadcast_asid_used. Why wouldn't broadcast_asid_used suffice?