Re: [PATCH v2 2/2] arm64: dts: qcom: eliza-cqs-evk: Enable sound card support with WSA8845 and DMIC

[Ravi Hothi <ravi.hothi@oss.qualcomm.com>]

On 7/17/2026 1:59 PM, Konrad Dybcio wrote:
> On 7/13/26 2:18 PM, Ravi Hothi wrote:
>> Enable the sound card on the Eliza CQS EVK platform, including the
>> WSA8845 external speaker path and DMIC microphone capture via VA macro.
>>
>> Enable the required LPASS WSA macro, VA macro and SoundWire controller
>> along with the necessary pinctrl configurations for DMIC and WSA
>> SoundWire interfaces.
>>
>> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
>> ---
> 
> [...]
> 
>> +	sound {
>> +		compatible = "qcom,eliza-sndcard", "qcom,sm8450-sndcard";
>> +		model = "eliza-cqs-evk";
> 
> Is there a reason only the CQS EVK gets audio support?
> i.e. is this setup not common across all the EVKs?

Currently we only have the CQS EVK upstream. Future EVK variants may 
have a different audio codec or configuration, so we are adding audio 
support specific to the CQS EVK for now.

Thanks,
Ravi Hothi

>> +
>> +		audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
>> +				"SpkrRight IN", "WSA_SPK2 OUT",
>> +				"VA DMIC0", "vdd-micb",
>> +				"VA DMIC1", "vdd-micb",
>> +				"VA DMIC2", "vdd-micb",
>> +				"VA DMIC3", "vdd-micb",
>> +				"VA DMIC4", "vdd-micb",
>> +				"VA DMIC5", "vdd-micb",
>> +				"VA DMIC6", "vdd-micb",
>> +				"VA DMIC7", "vdd-micb";
> 
> Are there actually 8 DMICs?

Yes, there are 8 DMICs

Thanks,
Ravi Hothi

> 
>> +
>> +		va-dai-link {
>> +			link-name = "VA Capture";
>> +
>> +			cpu {
>> +				sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
>> +			};
>> +
>> +			codec {
> 
> 'co'dec < 'cp'u

ACK, Will update in next version.

Thanks,
Ravi Hothi

> 
> [...]
> 
>> +	dmic_eldo: regulator-dmic-eldo {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "dmic-eldo";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		gpio = <&pm7550_gpios 8 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +		vin-supply = <&vreg_bob>;
>> +		regulator-boot-on;
> 
> Is it really boot-on?

Good catch, regulator-boot-on is not needed here.
Will fix in the next version.

Thanks,
Ravi Hothi

> 
>> +	};
>> +};
>> +
>> +&tlmm {
> 
> Label references should be sorted alphabetically

ACK, Will update in next version.

Thanks,
Ravi Hothi

> 
>> +	spkr_1_sd_n_active: spkr-1-sd-n-active-state {
>> +		pins = "gpio59";
>> +		function = "gpio";
>> +		drive-strength = <16>;
>> +		bias-disable;
>> +		output-low;
> 
> TLMM pins should not assert output state in the pinconf, the driver will
> take care of that through the GPIOD APIs

ACK, Will update in next version.

Thanks,
Ravi Hothi

> 
> On a note, these normally go through LPASS_TLMM, but I'm going to guess
> these pins are not muxable to ADSP?
> 

No, these GPIOs are not muxable to ADSP/LPASS on eliza. The WSA8845 SD_N 
lines are connected to main TLMM GPIOs on this board, not LPASS TLMM.

Thanks,
Ravi Hothi

> Konrad