Re: [PATCH net-next v21 1/3] dt-bindings: net: Document Motorcomm YT8824 PHY package

[Kyle Switch <kyle.switch@motor-comm.com>]

On 9/25/26 01:07, Conor Dooley wrote:
> On Thu, Sep 24, 2026 at 03:50:46PM +0800, Kyle Switch wrote:
>> Motorcomm YT8824 Ethernet PHY is PHY package of 4 PHY-s.
>>
>> Signed-off-by: Kyle Switch <kyle.switch@motor-comm.com>
>> ---
>>   .../bindings/net/motorcomm,yt8824.yaml        | 69 +++++++++++++++++++
>>   MAINTAINERS                                   |  2 +
>>   2 files changed, 71 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
>> new file mode 100644
>> index 000000000000..fd62b309e7ff
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
>> @@ -0,0 +1,69 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/motorcomm,yt8824.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: MotorComm YT8824 Ethernet PHY
>> +
>> +maintainers:
>> +  - Kyle Switch <kyle.switch@motor-comm.com>
>> +
>> +description:
>> +  Motorcomm YT8824 Ethernet PHY is a PHY package of 4 PHYs.
>> +
>> +$ref: ethernet-phy-package.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - motorcomm,yt8824-package
>> +  phy-mode:
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    enum: [ internal, 10g-qxgmii ]
> This should be after ref, but also have a vendor prefix.
> Additionally, the qcom ethernet-phy-package user also has a mode
> property. Net folks, should this be made common?
>
Ans: okay, The next version will follow the approach used by the qcom, 
package.
>> +  reg:
>> +    description:
>> +      The absolute MDIO address of the YT8824 shared top extend
>> +      register block.
>> +      For internal mode, this is fixed at 9;
>> +      For external mode it is (base MDIO address of the four
>> +      member PHYs) + 4.
>> +      Note that this is NOT the base ID of the first member PHY.
>> +required:
> Please use blank lines between properties and other elements of the
> binding.
>
Ans: okay.
>> +  - compatible
>> +  - phy-mode
>> +  - reg
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    mdio {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        ethernet-phy-package@9 {
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +            compatible = "motorcomm,yt8824-package";
>> +            reg = <9>;
>> +
>> +            phy-mode = "internal";
>> +
>> +            ethernet-phy@4 {
>> +                reg = <4>;
>> +            };
>> +
>> +            ethernet-phy@5 {
>> +                reg = <5>;
>> +            };
>> +
>> +            ethernet-phy@6 {
>> +                reg = <6>;
>> +            };
>> +
>> +            ethernet-phy@7 {
>> +                reg = <7>;
>> +            };
> Unless the addresses and numbers of phys are entirely unconstrained, I
> think you should add some pattern properties for them.

Ans: I'm somewhat confused on this point. What might the pattern properties

         you mentioned include? Could you provide more detail? thank you.

>
> Thanks,
> Conor.
>
>> +        };
>> +    };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e3ce77c839b0..ed7af1bd9521 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -18409,8 +18409,10 @@ F:	drivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c
>>   
>>   MOTORCOMM PHY DRIVER
>>   M:	Frank <Frank.Sae@motor-comm.com>
>> +M:	Kyle Switch <kyle.switch@motor-comm.com>
>>   L:	netdev@vger.kernel.org
>>   S:	Maintained
>> +F:	Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml
>>   F:	Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
>>   F:	drivers/net/phy/motorcomm.c
>>   
>> -- 
>> 2.25.1
>>