mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Donald Shannon <donalds@nvidia.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: joel@jms.id.au, andrew@codeconstruct.com.au,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: Add NVIDIA GB200-UT3.0b board
Date: Wed, 23 Jul 2025 14:58:14 -0700	[thread overview]
Message-ID: <24ce8704-1f9c-437e-ae72-1c6c3c672c2b@nvidia.com> (raw)
In-Reply-To: <d85fa0c5-f155-431e-bc09-0bb74d96d670@kernel.org>

On 7/22/25 22:56, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 23/07/2025 03:42, Donald Shannon wrote:
>> This is an Aspeed AST2600 based unit testing platform for GB200.
>> UT3.0b is different than nvidia-gb200nvl-bmc due to networking topology
>> differences, additional gpio expanders, and voltage regulator gating
>> some devices.
>>
>> Reference to Ast2600 SOC [1].
>> Reference to Blackwell GB200NVL Platform [2].
>>
>> Link: https://www.aspeedtech.com/server_ast2600/ [1]
>> Link: https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2]
>> Signed-off-by: Donald Shannon <donalds@nvidia.com>
>> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Why are you faking tags? No, you cannot just add whatever you want.
>
> Best regards,
> Krzysztof

Hi Krzysztof,

I think I was confused by your message on my V5 patch. I will remove the Acked-by and resubmit:

>A nit, subject: drop second/last, redundant "binding". The
>"dt-bindings" prefix is already stating that these are bindings.
>See also:
>https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
>With above two:
>
>Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
><form letter>
>This is an automated instruction, just in case, because many review
>tags are being ignored. If you know the process, just skip it entirely
>(please do not feel offended by me posting it here - no bad intentions
>intended, no patronizing, I just want to avoid wasted efforts). If you
>do not know the process, here is a short explanation:
>
>Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>versions of patchset, under or above your Signed-off-by tag, unless
>patch changed significantly (e.g. new properties added to the DT
>bindings). Tag is "received", when provided in a message replied to you
>on the mailing list. Tools like b4 can help here ('b4 trailers -u ...').
>However, there's no need to repost patches *only* to add the tags. The
>upstream maintainer will do that for tags received on the version they
>apply.

Thanks,
Donald


  reply	other threads:[~2025-07-23 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23  1:42 [PATCH v6 0/2] Adding device tree and binding for NVIDIA GB200-UT3.0b Donald Shannon
2025-07-23  1:42 ` [PATCH v6 1/2] dt-bindings: arm: aspeed: Add NVIDIA GB200-UT3.0b board Donald Shannon
2025-07-23  5:56   ` Krzysztof Kozlowski
2025-07-23 21:58     ` Donald Shannon [this message]
2025-07-24  7:15       ` Krzysztof Kozlowski
2025-07-23  1:42 ` [PATCH v6 2/2] ARM: dts: aspeed: Add NVIDIA GB200 UT3.0b board Donald Shannon
2025-07-23  4:19 ` [PATCH v6 0/2] Adding device tree and binding for NVIDIA GB200-UT3.0b Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24ce8704-1f9c-437e-ae72-1c6c3c672c2b@nvidia.com \
    --to=donalds@nvidia.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®