From: Jens Axboe <axboe@kernel.dk>
To: Dennis Zhou <dennisszhou@gmail.com>, Tejun Heo <tj@kernel.org>,
Josef Bacik <jbacik@fb.com>, Johannes Weiner <hannes@cmpxchg.org>
Cc: kernel-team@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] block: make iolatency avg_lat exponentially decay
Date: Thu, 2 Aug 2018 09:58:32 -0600 [thread overview]
Message-ID: <24d21a5c-f061-63ca-4571-ed32f1c8e2d3@kernel.dk> (raw)
In-Reply-To: <20180802061541.49173-1-dennisszhou@gmail.com>
On 8/2/18 12:15 AM, Dennis Zhou wrote:
> From: "Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
>
> Currently, avg_lat is calculated by accumulating the mean of every
> window in a long running cumulative average. As time goes on, the metric
> becomes less and less useful due to the accumulated history.
>
> This patch reuses the same calculation done in load averages to make the
> avg_lat metric more lively. Unlike load averages, the avg only advances
> when a window elapses (due to an io). Idle periods extend the most
> recent window. Bucketing is used to limit the history of avg_lat by
> binding it to the window size. So, the window range for 1/exp (decay
> rate) is [1 min, 2.5 min) when windows elapse immediately.
>
> The current sample window size is exposed in the debug info to enable
> calculation of the window range.
Applied for 4.19, thanks Dennis.
--
Jens Axboe
next prev parent reply other threads:[~2018-08-02 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 6:15 Dennis Zhou
2018-08-02 15:58 ` Jens Axboe [this message]
2018-08-02 15:59 ` Tejun Heo
2018-08-02 16:01 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24d21a5c-f061-63ca-4571-ed32f1c8e2d3@kernel.dk \
--to=axboe@kernel.dk \
--cc=dennisszhou@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®