From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A570DC433DB for ; Sat, 23 Jan 2021 23:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E2722CB3 for ; Sat, 23 Jan 2021 23:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726398AbhAWX47 (ORCPT ); Sat, 23 Jan 2021 18:56:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbhAWX45 (ORCPT ); Sat, 23 Jan 2021 18:56:57 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAC39C0613D6; Sat, 23 Jan 2021 15:56:16 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id h7so12747733lfc.6; Sat, 23 Jan 2021 15:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T9IQA43+iHU7clo6ySQk47UiflrToIRPUItvcZy5xwQ=; b=nbnEqrQRTfaMjj5a2wOeEPazP7sDVMGZCgcLFhyAuufpTqepvGrF0Fq3GbtAXHqgyL AFMEEBIfJ4wqMooL9WB2UhT5BL6fHTpiJ0UGcjjY8eSTE32G5qogKNLc6yPnlNvIXPpm YMCSsEPjmJpDQCaliT0t1M1IMdDUhuIN+ro+ESJq+N7bYY3Xlca1zHLTzrdjXzA5g7RG uV5RYOa1/Xpz8Ssvz3/V0/D7vvOkK0za21CmifZzVaJtmDMUO3qa203pNtoNOllPQEtR qRZG39S4RaTJeCk5vAvlgRaikqHQStPk8bPCzWy+DWQEnErrJxjvEX9+C4h1OkG54TYF ERQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T9IQA43+iHU7clo6ySQk47UiflrToIRPUItvcZy5xwQ=; b=n5kLVDHWEc2RbaFCKKZMbwjf+kt1LFJ8cvgNDtDhFKouxIQA6VY9DZhO+D+DsL0gQA VORtYRAgMo+c1cxXeOFbJENw8CRVhyngQ44nehcjRx1sV3e+Dcav2pL0lsyMIDv0eCub r1B84wAUBWeJwNCvoPB/6Sjdu7T+rhViPA/J15C3uUKimvG+3WI70biD/hQQmu4biS5H ngG/R4RNj9TfB9LIwKEd31Zkn8s9Ohf7w189W2P0h3qVll4d1UXyMuNQEIiM+91G+Zd8 iQkN1CgI/iHj1w5LA0tiRIZooW1XzGc9p4aDHanvbv+7rlGulPOhCF/aOl6UeqXyZ8l5 3z8A== X-Gm-Message-State: AOAM530vF0Q5IKLMcBZ8gY+s+KtqQ5S2b2+WuLzOE7qj+tPrjyMG9fAZ hB7fFQTHmwW/D5MUdDsgFrUM/rnMMLA= X-Google-Smtp-Source: ABdhPJz41cCn8Y/V/v3MtOfBG/dT0MaGDym/74GGUaVDEnBChug3GcVuAPvzrBpgoqgQccgTn1eDBg== X-Received: by 2002:ac2:51c9:: with SMTP id u9mr340219lfm.276.1611446174611; Sat, 23 Jan 2021 15:56:14 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id o5sm1484944lji.133.2021.01.23.15.56.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jan 2021 15:56:13 -0800 (PST) Subject: Re: [PATCH v1 0/3] Support building gpio-tegra driver as loadable module To: Linus Walleij Cc: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Bartosz Golaszewski , linux-tegra , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" References: <20210122185543.16554-1-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <24d46928-8c57-acba-f9cf-49afbe4c983c@gmail.com> Date: Sun, 24 Jan 2021 02:56:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 24.01.2021 01:50, Linus Walleij пишет: > On Fri, Jan 22, 2021 at 7:59 PM Dmitry Osipenko wrote: > >> This small series adds modularization support to the gpio-tegra driver, >> i.e. driver now could be built as a loadable kernel module. >> >> Dmitry Osipenko (3): >> gpio: tegra: Use debugfs_create_devm_seqfile() >> gpio: tegra: Clean up whitespaces in tegra_gpio_driver >> gpio: tegra: Support building driver as a loadable module > > As these three patches clearly make the kernel look better after > than before: > Reviewed-by: Linus Walleij > > However when we are doing this I would strongly encourage you > to also make a patch implementing remove() so you can insmod > rmmod the module at runtime. The remove() is optional for drivers, it doesn't prevent the rmmod.