From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbdHVVpx (ORCPT ); Tue, 22 Aug 2017 17:45:53 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37520 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbdHVVpv (ORCPT ); Tue, 22 Aug 2017 17:45:51 -0400 Subject: Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print() To: David Miller Cc: netdev@vger.kernel.org, romain.perier@collabora.com, alexandre.torgue@st.com, peppe.cavallaro@st.com, plaes@plaes.org, andrew@lunn.ch, linux-kernel@vger.kernel.org References: <20170822212647.11520-1-f.fainelli@gmail.com> <20170822.144414.545771080170074088.davem@davemloft.net> From: Florian Fainelli Message-ID: <24d4774e-1b1b-fe8b-5d25-dcd7f7aae757@gmail.com> Date: Tue, 22 Aug 2017 14:45:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170822.144414.545771080170074088.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/22/2017 02:44 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 22 Aug 2017 14:26:47 -0700 > >> Priit reported that stmmac was crashing with the trace below. This is because >> phy_attached_print() is called too early right after the PHY device has been >> found, but before it has a driver attached, since that is only done in >> phy_probe() which occurs later. >> >> Fix this by dealing with a possibly NULL phydev->drv point since that can >> happen here, but could also happen if we voluntarily did an unbind of the >> PHY device with the PHY driver. > ... >> Tested-By: Priit Laes >> Fixes: fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register") >> Signed-off-by: Florian Fainelli > > "net-next"? The commit which introduced this problem is in 'net', don't we want > to fix it there? Oh yes we do, somehow I thought the commit was just in "net-next" hence the subject, the patch applies cleanly to "net" as well. Thanks! -- Florian