From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751470AbdFGPbC (ORCPT ); Wed, 7 Jun 2017 11:31:02 -0400 Received: from mail-wr0-f170.google.com ([209.85.128.170]:33421 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbdFGPbA (ORCPT ); Wed, 7 Jun 2017 11:31:00 -0400 Subject: Re: [PATCH 2/3] nvmem: core: add locking to nvmem_find_cell To: Heiner Kallweit , Linux Kernel Mailing List References: <32c019d9-656d-6214-af2a-bef7e91dc1de@gmail.com> From: Srinivas Kandagatla Message-ID: <24d689a7-bc27-e384-3741-efd9e6221bcb@linaro.org> Date: Wed, 7 Jun 2017 16:30:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/17 12:01, Heiner Kallweit wrote: > Adding entries to nvmem_cells and deleting entries from it is > protected by nvmem_cells_mutex. Therefore this mutex should > also protect iterating over the list. > > Signed-off-by: Heiner Kallweit > --- > drivers/nvmem/core.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 4e07f3f8..1aa6d25a 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -286,9 +286,15 @@ static struct nvmem_cell *nvmem_find_cell(const char *cell_id) > { > struct nvmem_cell *p; > > + mutex_lock(&nvmem_cells_mutex); > + > list_for_each_entry(p, &nvmem_cells, node) > - if (p && !strcmp(p->name, cell_id)) > + if (p && !strcmp(p->name, cell_id)) { > + mutex_unlock(&nvmem_cells_mutex); > return p; > + } > + > + mutex_unlock(&nvmem_cells_mutex); > Thanks for the patch, I will queue this up. Thanks, srini > return NULL; > } >