From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6106C388F9 for ; Tue, 17 Nov 2020 03:35:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C5E324697 for ; Tue, 17 Nov 2020 03:35:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="F07ESBNP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbgKQDfe (ORCPT ); Mon, 16 Nov 2020 22:35:34 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:17204 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726471AbgKQDfd (ORCPT ); Mon, 16 Nov 2020 22:35:33 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 16 Nov 2020 19:35:42 -0800 Received: from [10.2.57.97] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 17 Nov 2020 03:35:31 +0000 Subject: Re: [mm/gup] 47e29d32af: phoronix-test-suite.npb.FT.A.total_mop_s -45.0% regression To: kernel test robot CC: Linus Torvalds , Jan Kara , Andrew Morton , "Kirill A. Shutemov" , Ira Weiny , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , "Matthew Wilcox (Oracle)" , Al Viro , Christoph Hellwig , Dan Williams , Dave Chinner , "Jason Gunthorpe" , Jonathan Corbet , Michal Hocko , Mike Kravetz , Shuah Khan , Vlastimil Babka , LKML , , , , , , , , , , , , , , , , , , , , References: <20201117024825.GA8169@xsang-OptiPlex-9020> From: John Hubbard Message-ID: <24d9d093-5b7a-9aee-8d61-59c0007a9269@nvidia.com> Date: Mon, 16 Nov 2020 19:35:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201117024825.GA8169@xsang-OptiPlex-9020> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605584142; bh=jUB+JFDnCaI8NY05B0D8nF6NzAFcD+Qxv1P77ibpmMA=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=F07ESBNPFPoa50t0XaFH70E592EfoMKhT68hjwyKJv/eYA43772o8TD5I7gbraIgE lW2rAbviJdAqFu/MGmhg6mr3jN0pBQMq6M+LMDSSE4Ot0S8bwyeLrooyiUY5vKMX3A ugVrUmaU8B2BlfoiFG1nyRmn7yT3XVINLPYw0BkGofoECd7MJehD2/v3zxYi+xKijU Obla3Ico7koaL9qybj7PqxfqyHApCDDlO2v15VOTQRqZFz/2dTlIWhfRQQR6hYyPkt Ak2VRDAacwWY5V5ihmW2g6q8BpVDg7GXEFfDzX0yySWNeNKzxnnGotc6CakJZmG+34 ok0gxRp6RLSNw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/20 6:48 PM, kernel test robot wrote: >=20 > Greeting, >=20 > FYI, we noticed a -45.0% regression of phoronix-test-suite.npb.FT.A.total= _mop_s due to commit: >=20 That's a huge slowdown... >=20 > commit: 47e29d32afba11b13efb51f03154a8cf22fb4360 ("mm/gup: page->hpage_pi= nned_refcount: exact pin counts for huge pages") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master ...but that commit happened in April, 2020. Surely if this were a serious i= ssue we would have some other indication...is this worth following up on?? I'm incl= ined to ignore it, honestly. thanks, --=20 John Hubbard NVIDIA >=20 >=20 > in testcase: phoronix-test-suite > on test machine: 96 threads Intel(R) Xeon(R) Gold 6252 CPU @ 2.10GHz with= 192G memory > with following parameters: >=20 > test: npb-1.3.1 > option_a: FT.A > cpufreq_governor: performance > ucode: 0x5002f01 >=20 > test-description: The Phoronix Test Suite is the most comprehensive testi= ng and benchmarking platform available that provides an extensible framewor= k for which new tests can be easily added. > test-url: http://www.phoronix-test-suite.com/ >=20 >=20 >=20 > If you fix the issue, kindly add following tag > Reported-by: kernel test robot >=20 >=20 > Details are as below: > -------------------------------------------------------------------------= -------------------------> >=20 >=20 > To reproduce: >=20 > git clone https://github.com/intel/lkp-tests.git > cd lkp-tests > bin/lkp install job.yaml # job file is attached in this email > bin/lkp run job.yaml >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > compiler/cpufreq_governor/kconfig/option_a/rootfs/tbox_group/test/testcas= e/ucode: > gcc-9/performance/x86_64-rhel-8.3/FT.A/debian-x86_64-phoronix/lkp-csl-= 2sp8/npb-1.3.1/phoronix-test-suite/0x5002f01 >=20 > commit: > 3faa52c03f ("mm/gup: track FOLL_PIN pages") > 47e29d32af ("mm/gup: page->hpage_pinned_refcount: exact pin counts for= huge pages") >=20 > 3faa52c03f440d1b 47e29d32afba11b13efb51f0315 > ---------------- --------------------------- > fail:runs %reproduction fail:runs > | | | > 1:4 -25% :4 kmsg.Spurious_LAPIC_timer_= interrupt_on_cpu > %stddev %change %stddev > \ | \ > 4585 =C2=B1 2% -45.0% 2522 phoronix-test-suite.n= pb.FT.A.total_mop_s > 1223 =C2=B1 4% +40.2% 1714 phoronix-test-suite.t= ime.percent_of_cpu_this_job_got >=20 >=20 > = =20 > phoronix-test-suite.npb.FT.A.total_mop_s > = =20 > 6500 +----------------------------------------------------------------= ----+ > | .+. .+. .+. = | > 6000 |.+ +.+.+.++.+.+.+.+.+.+.+ +.+.++ +.+.+.+.+.+.+.+.+.++.+ = | > 5500 |-+ : = | > | : = | > 5000 |-+ : = | > 4500 |-+ +.= +.+.| > | = | > 4000 |-+ = | > 3500 |-+ = | > | = | > 3000 |-+ = | > 2500 |-+ O O O = | > | O O O O O OO O O O O O O O O O O = | > 2000 +----------------------------------------------------------------= ----+ > = =20 > = =20 > [*] bisect-good sample > [O] bisect-bad sample >=20 >=20 >=20 > Disclaimer: > Results have been estimated based on internal Intel analysis and are prov= ided > for informational purposes only. Any difference in system hardware or sof= tware > design or configuration may affect actual performance. >=20 >=20 > Thanks, > Oliver Sang >=20