From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 716B81CABA; Sun, 27 Oct 2024 18:16:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730053019; cv=none; b=GiuXMOk9i3XUyCYBm9QreZu9ezQLRW2PD+ykMrq+sr4TFUvRlH9BssnBTmfgo32CeCd2qlUx15S/SRYNmw/hEyYo28Fh9bsKvnwX/lkRgTaWm+sBrvQBvV7idLjj4qhGINZSg5memnY5JQmB1BXhXg9F+rIcT/fkHbGWtazVAoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730053019; c=relaxed/simple; bh=k5DTPcbcVHWNuO7WqRv0e+WjFUH9BaOCY6fGphEXW4A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B5g4IWX7Iq5dHuPBCJWbEIFF8OgBFUJKTXDUHNkLqh2sJeP3I4yqKmKPUrFC+T1zuf7B/Ce4tDDB/hsk0vTXog1kJJ2gplWmKKsCcOEVdBZ/QwzFW94aOXZX68aTY2fj/W02DPXdTdFjV1pgrNAebK/SZJqYd093YPOwJj8qYfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DxANetuG; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DxANetuG" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-207115e3056so29124685ad.2; Sun, 27 Oct 2024 11:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730053017; x=1730657817; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=YGouoi2JyMMUSL4uwzkw3miQ+EC37EMawkaEdIcWtHo=; b=DxANetuGf/ASBUzA5S/9lfQIxVGwFhSrkiVpGe9PyvLQ9p5CY9ZKfpgVMpsvN3PHlI WoVUVpUJez1ZnZO8dVjvh4yWlNRZlK/VQorISzTwXKj1QIdupGWaYSsyHWXK8fqORhh6 e/Zf9XbNO265rMvmnX0r1Y6g/xLuyQ5KuXYViRe0uizl4W/Px4H73hB17jAEjTqr4qJz 3/zA3nUR0zsv/EAyonYQyNDhtow0C6DSdkxoXdy6DFbqIcjnAcHCBDYBv72axUx9G6o/ pKh1vFyUg1ib93bR9EFQ5uHUOrhbsRWxF9nwlk92jpUitj4+ne4LCFXchlDXnw07MXEG 8s/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730053017; x=1730657817; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YGouoi2JyMMUSL4uwzkw3miQ+EC37EMawkaEdIcWtHo=; b=A/RwyyWEmBuIXiV7kHuDYco3lU61XDIO2RvuFva09u6vQBGGwBUHQd+qMfEasvkm1u 0vE4hwLHz9BqibtjngTpvN1PmX1GR9Rw//qatyvLHdzC/7O0A8Cthkna2gfjxBiSzPBr wAsQz3NAbo6CQe3+SaaoSgMB+TJZSL27ubAueEnb1uJbudr16fpqeIudn1yiaeMX5dpR sGPFHrrmydcfBeE/NolwffMq6xddnc7/D4kyAghGSwK/18IoTnE6whl2kpYg2r4cAsLe G29uxRCuPmPq1j6N92Akvo0D8koKW8UnvNKv1TEM08YsHvBzlaXXk5uEvPHusRhuBIwX kULg== X-Forwarded-Encrypted: i=1; AJvYcCUL/XgHO+/5bcce7F6FnUQbg1Rvp2PXH/7BNm+3mi0PYbP0/XfqJNuM3PfJhRFqQwcIOWYAxTlqdzNnnA==@vger.kernel.org, AJvYcCVoBEYQ1PAEK+UgG3hEHb+5PTtXk/KYhjJ6YkbCoKRuL8mkCNKLMRMkctocxkFF2pmiR0u6FxAZeNtCLBgT@vger.kernel.org X-Gm-Message-State: AOJu0Yw3AIC+Gwk09pUulYneUjaIADAgjtmaGbgN1mv7vevaT437wq8i Ps5+a/kHNfeS8a+Kvg3LWB5x8jwWPO+jNYMVLBMc5+mjCHpPoEbF X-Google-Smtp-Source: AGHT+IFCnXZFuDM6dpCi4qofKY7ZFavu5Knt8J+0Rk9KRFWG6Rp2WDR/KA8YrVJCFSrb9lM9xV69ag== X-Received: by 2002:a17:902:fc4c:b0:202:26d:146c with SMTP id d9443c01a7336-210c68728f3mr82006185ad.5.1730053016600; Sun, 27 Oct 2024 11:16:56 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc082736sm37969735ad.288.2024.10.27.11.16.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Oct 2024 11:16:55 -0700 (PDT) Sender: Guenter Roeck Message-ID: <24dc65c2-b6c9-4909-a784-fb81d9299f1c@roeck-us.net> Date: Sun, 27 Oct 2024 11:16:54 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] hwmon: pwm_enable clarification To: "Derek J. Clark" Cc: Jean Delvare , Jonathan Corbet , Cryolita PukNgae , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241027174836.8588-1-derekjohn.clark@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20241027174836.8588-1-derekjohn.clark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/27/24 10:48, Derek J. Clark wrote: > Greetings all, > > I am working with Cryolita to fix up the GPD driver she submitted recently: > https://lore.kernel.org/all/20240718-gpd_fan-v4-0-116e5431a9fe@gmail.com/ > > We are currently having a discussion about the meaning of this part of the > documentation and are seeking some guidance from upstream. > >> pwm[1-*]_enable >> Fan speed control method: >> 0: no fan speed control (i.e. fan at full speed) >> 1: manual fan speed control enabled (using pwm[1-*]) >> 2+: automatic fan speed control enabled >> Check individual chip documentation files for automatic mode >> details. >> RW > > In oxp-sensors we took 0 to mean "no kernel control" so a setting of 0 is > technically "automatic" but fully controlled by the hardware with no > interaction from the driver. In her original driver draft she had taken this That is wrong. It should be (or have been) 2 or higher. Ah yes, I can see that the code sets fan control to automatic when oxp_pwm_disable() is called. Again, that is wrong. Congratulations to the submitters, you sneaked that by my review. That doesn't make it better. It is still wrong, and I call it "sneaky" because the function is not called "oxp_pwm_automatic()" or similar, it is called "oxp_pwm_disable(). Setting fan control to automatic does not disable fan control. My bad, I should have paid closer attention, and/or maybe not have trusted the submitters as much as I did. I guess I'll have to pay closer attention in the future. > literally to have the driver set the fan speed to 100% on this setting rather > then give back control to the hardware. My question is simply what is the > correct interpretation here? Ideally I would like to see this interface match It seems to me that the above text is well defined. > as existing userspace software is expecting 0 as hardware controlled and 1 as > manually controlled, but we also want to ensure this is correct before we > submit a v5. > Any such userspace expectations are simply wrong. The ABI definition is above and, again, it is well defined. 0: no fan speed control (i.e. fan at full speed) I don't really see any ambiguity in this text. This isn't about kernel control, it is an absolute statement. There is no "kernel" in "no fan speed control". "fan at full speed" should make this even more obvious. Guenter