From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
xen-devel <xen-devel@lists.xenproject.org>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration
Date: Fri, 29 Mar 2019 09:42:27 -0400 [thread overview]
Message-ID: <24df98be-21e7-617e-7651-ae34e2a2e512@oracle.com> (raw)
In-Reply-To: <5C9DDD530200007800222B22@prv1-mh.provo.novell.com>
On 3/29/19 4:54 AM, Jan Beulich wrote:
>>>> On 28.03.19 at 17:50, <boris.ostrovsky@oracle.com> wrote:
>>
>> Given especially xen_pv_smp_prepare_cpus(), I think re-working proper
>> setting of present/possible masks is well beyond the scope of your
>> original patch.
> Well, then the question is, what (if any) changes are you
> expecting me to make for this change to be acceptable? Or do
> you perhaps want me to add a 2nd patch on top addressing
> the other outlined anomalies?
If your goal is just to fix the dom0_max_vcpus issue then this patch is
sufficient (but the commit message should say that this is what the
patch is for).
But if you are trying to make cpu masks management done properly then I
think this patch alone does not address this fully.
-boris
next prev parent reply other threads:[~2019-03-29 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:12 Jan Beulich
2019-03-27 17:07 ` Boris Ostrovsky
2019-03-28 9:03 ` Jan Beulich
2019-03-28 16:50 ` Boris Ostrovsky
2019-03-29 8:54 ` Jan Beulich
2019-03-29 13:42 ` Boris Ostrovsky [this message]
2019-03-29 15:12 ` Jan Beulich
2019-03-29 15:46 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24df98be-21e7-617e-7651-ae34e2a2e512@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®