From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2861F471F for ; Mon, 16 Mar 2026 14:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671442; cv=none; b=KBRAph6ABQVfafWXe1Ez5hErk6X8A9RODAQclE0L0woQGVzisboq4ihnm7k5xFneNDvIQUHPoyQ1taRXhREAJ25bMCtmSurD1/QTLkFyoa97Nrb/acTpMLh4/ppbtL05ELKvx487TgtxtlbBqnJRZGc6gKeA/ROei2qrT21CDKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671442; c=relaxed/simple; bh=cEyG5YXUx0ZQmxP+ZyNH9nRSEKM89hL30ZYmM7WDaBM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=friOxiebwwZtr9L6FXvzUWyKI7nqHORCLE1RZl6p0a2BMRQPbAF77NYgJMz4VAuqXEaCNvQqE2A7VbqgE755bj5HFxmNobvGbuU05+yI0YlUihpGCCfN+IHnyaRRb85rwIMliFGLrf1E3dINs27p4SKdh97MrHd87Sz/bJWQo4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W9QwDwIf; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W9QwDwIf" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2aae146b604so29824885ad.3 for ; Mon, 16 Mar 2026 07:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773671440; x=1774276240; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=EM6I/UsUw4bHIFNWZ1zqR+/GZEx2ravn0mEVzQtZNqk=; b=W9QwDwIfXBxVzCwDZAHN9qhKEwKXu9r+dpVkDaXk0Kb5zuol6zP3fKHws6nDjEmpFr T9AowkZqgUA3/qJQ8Qr9g0/2qCMhDgkV/5MeswpFrtOerpsXiXGORzyqhKg/R5e609FN hM2wJk1uDQ+3wxPmEvFYQmzOG/PVqjreJTngExwatoiGF8vDS8VdvgyJ6bG+iQbhc+RE cpJAN+3RvsZSt901EZGgmPX+s0ex/f7ApJRqMHfX8URtnD4Nl5tn+uEO2vzyZ7ixhcka IaJnyMS9kdECV20QoVnQ0OfsdejUREhSYDE1bXcqqGlSkK8amDx/tAl8c2ANEk04gDij oIbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773671440; x=1774276240; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EM6I/UsUw4bHIFNWZ1zqR+/GZEx2ravn0mEVzQtZNqk=; b=B82Qt+wQAnRzLpmIdNbsjYrwZS9IKySO8j4AchQSX5HN88jFzojt4c+veUvon+xRhP 9bgKWODa9Q80VNJRZzTL9T8ara9+Ksc61G+Bl0Zy7hQqBu3fIxBIwAiZFeN9vhZA67Vo WFqUiiCbTfjPCwesjSalbvhcongVolfdqpYBD9fvyzRoLCbFrrf5gFoq9tXPg7TcWddK xfNBXvX7q6f+tCyQeCoD2MuBXsyjCNBZ+qOZmOd77lpaPkFvLvkBe0GFy2C15g/dlNRE JvazW4CQvEt9KPkeG7Wi3NxfljRuIAydNj+arN3zuI9u5wivP6iRERCvk6NkQ3nh7mKc svVA== X-Forwarded-Encrypted: i=1; AJvYcCWbkuWLNWR5cqB6oPwkIkmzKWG/KV6QhLr27KJQCmCmFS1fmF1/NbxZivox/0zpMLwQ1SpbsIHaYxBwgyw=@vger.kernel.org X-Gm-Message-State: AOJu0YyYsHFRdvHnOckdlAPSo9jV5XQ07uNaARjLaGF4gkvOCJCChzc6 OID9nVnGbJo1h1MgeBUgEh0Hm420DDw2WwHi9jO5ZzyoI9LA9i3vWsn9aiz0GQ== X-Gm-Gg: ATEYQzx3HCOjTWPM51yXKfyyyHRQMrNPIc9dOqNsQB6DhkZMmW+f7pf8WvKClHjITqs nM9xxmhGIa33pcOYenv9nFf4wySHfXTyMg+Kry65zCyaykGgsPBDtjIUuCIWzvuqHoGZxp/8Z7+ jq0St28I6iRsNQzjxEK2h1cT1pa+/fFAYsrcF53QQKWvRPjjCuEsBN+wGuAr29EDtWFvOPNf/3m cqO9+/n87+CovZSFAD82rOMsCdIugTrACA3N9c42zU62+Sjcgv3cnOu9kZN8JuCNXn1xVdt4xln kHWRwJRVtLjw7hV63qcXW4hvgRmRY62701idnJFm/9od2ZWwfWF6yxnN3lx76xiFelCp2tkN+WF 2GOXjWBdq/Htpy6F2fmX3EMD6by6C4DD/zo8ith72keWRKBebGtBbPsIfZMtS0ZrczHZkibv1f3 Zz6fopIpVKuJ2pFj1DTzqFQJ4qHbeJROzHheQzLk4= X-Received: by 2002:a17:902:f542:b0:2ae:3dcc:eb19 with SMTP id d9443c01a7336-2aeca9c8377mr127095155ad.19.1773671440358; Mon, 16 Mar 2026 07:30:40 -0700 (PDT) Received: from [192.168.0.213] ([60.49.20.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece56cca6sm120296945ad.3.2026.03.16.07.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 07:30:39 -0700 (PDT) Message-ID: <24e712c9-6d45-4a23-9bfc-0b0202acfc98@gmail.com> Date: Mon, 16 Mar 2026 22:30:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] firmware: stratix10-svc: add missing comment for fcs client To: Dinh Nguyen , linux-kernel@vger.kernel.org References: <20260315031831.8911-1-karom.9560@gmail.com> Content-Language: en-US From: Khairul Anuar Romli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/3/2026 8:13 pm, Dinh Nguyen wrote: > Hi Khairul, > > On 3/14/26 22:18, Khairul Anuar Romli wrote: >> Add the missing comment describing the fcs client as "fpga crypto >> services" >> in the SVC client list. This keeps the documentation consistent with >> other >> clients (fpga, rsu, hwmon) and improves readibility and mantainability. >> >> Signed-off-by: Khairul Anuar Romli >> --- >>   include/linux/firmware/intel/stratix10-svc-client.h | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/ >> include/linux/firmware/intel/stratix10-svc-client.h >> index d290060f4c73..74adf34d6142 100644 >> --- a/include/linux/firmware/intel/stratix10-svc-client.h >> +++ b/include/linux/firmware/intel/stratix10-svc-client.h >> @@ -12,6 +12,7 @@ >>    * >>    * fpga: for FPGA configuration >>    * rsu: for remote status update >> + * fcs: for fpga crypto services > > > Thanks for your patch, but for now there is no fcs in the driver yet. In > order to minimize churn, we'll add this when there is an fcs driver. > > Dinh > Noted. Thanks for letting me know. Best Regards, Khairul