From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22479C04ABB for ; Wed, 12 Sep 2018 01:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B213120866 for ; Wed, 12 Sep 2018 01:46:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B213120866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbeILGsv (ORCPT ); Wed, 12 Sep 2018 02:48:51 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:59777 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726686AbeILGsv (ORCPT ); Wed, 12 Sep 2018 02:48:51 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E7CD54D662D55; Wed, 12 Sep 2018 09:46:45 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.399.0; Wed, 12 Sep 2018 09:46:44 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data From: Chao Yu To: Jaegeuk Kim CC: Chao Yu , , References: <20180911201546.56566-1-jaegeuk@kernel.org> <7aa2e6f3-a4b2-dfdd-6205-f19c4bc952e6@kernel.org> <20180912000603.GA67662@jaegeuk-macbookpro.roam.corp.google.com> <20180912002700.GA69323@jaegeuk-macbookpro.roam.corp.google.com> <650f06f4-7ca3-a3ed-d149-88d1e9f93b7a@huawei.com> <20180912012550.GA71953@jaegeuk-macbookpro.roam.corp.google.com> Message-ID: <24ee1c19-ccc1-31db-12d0-30ac76fd645e@huawei.com> Date: Wed, 12 Sep 2018 09:46:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/9/12 9:40, Chao Yu wrote: > On 2018/9/12 9:25, Jaegeuk Kim wrote: >> On 09/12, Chao Yu wrote: >>> On 2018/9/12 8:27, Jaegeuk Kim wrote: >>>> On 09/11, Jaegeuk Kim wrote: >>>>> On 09/12, Chao Yu wrote: >>>>>> On 2018/9/12 4:15, Jaegeuk Kim wrote: >>>>>>> fsck.f2fs is able to recover the quota structure, since roll-forward recovery >>>>>>> can recover it based on previous user information. >>>>>> >>>>>> I didn't get it, both fsck and kernel recover quota file based all inodes' >>>>>> uid/gid/prjid, if {x}id didn't change, wouldn't those two recovery result be the >>>>>> same? >>>>> >>>>> I thought that, but had to add this, since I was encountering quota errors right >>>>> after getting some files recovered. And, I thought it'd make it more safe to do >>>>> fsck after roll-forward recovery. >>>>> >>>>> Anyway, let me test again without this patch for a while. >>>> >>>> Hmm, I just got a fsck failure right after some files recovered. >>> >>> To make sure, do you test with "f2fs: guarantee journalled quota data by >>> checkpoint"? if not, I think there is no guarantee that f2fs can recover >>> quote info into correct quote file, because, in last checkpoint, quota file >>> may was corrupted/inconsistent. Right? > > Oh, I forget to mention that, I add a patch to fsck to let it noticing > CP_QUOTA_NEED_FSCK_FLAG flag, and by default, fsck will fix corrupted quote > file if the flag is set, but w/o this flag, quota file is still corrupted > detected by fsck, I guess there is bug in v8. In v8, there are two cases we didn't guarantee quota file's consistence: 1. flush time in block_operation exceed a threshold. 2. dquot subsystem error occurs. For above case, fsck should repair the quota file by default. > > Can you add that in fsck too? so we can separate real kernel bug and quota > file corruption due to dquot subsystem error caused like below case: > > +static int f2fs_dquot_acquire(struct dquot *dquot) > +{ > + int ret; > + > + ret = dquot_acquire(dquot); > + if (ret == -ENOSPC || ret == -EIO) > + set_sbi_flag(F2FS_SB(dquot->dq_sb), SBI_QUOTA_NEED_REPAIR); > + return ret; > +} > >> >> I hit the failure with v8. And, the test scenario is 1) enable fault injection >> 2) run fsstress, 3) call shutdowon, 4) kill fsstress, 5) unmount, 6) fsck, 7) >> mount, 8) fsck, 9) go 1). 8) fsck is do fscking in a mounted image? Thanks, >> >> So, I'm hitting failure in 8) fsck. I expect 6) fsck should fix any corruption >> and 7) recovered some files on clean checkpoint. > > I see, I can add this case too, does this exist in your xfstest tree in github? > > Thanks, > >> >> Thanks, >> >>> >>> Thanks, >>> >>>> >>>>> >>>>> Thanks, >>>>> >>>>> >>>>>> >>>>>> Thanks, >>>>>> >>>>>>> >>>>>>> Signed-off-by: Jaegeuk Kim >>>>>>> --- >>>>>>> fs/f2fs/recovery.c | 3 +++ >>>>>>> 1 file changed, 3 insertions(+) >>>>>>> >>>>>>> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c >>>>>>> index 95511ed11a22..1fde86a2107e 100644 >>>>>>> --- a/fs/f2fs/recovery.c >>>>>>> +++ b/fs/f2fs/recovery.c >>>>>>> @@ -675,6 +675,9 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) >>>>>>> >>>>>>> need_writecp = true; >>>>>>> >>>>>>> + /* quota is not fully updated due to the lack of user information. */ >>>>>>> + set_sbi_flag(sbi, SBI_NEED_FSCK); >>>>>>> + >>>>>>> /* step #2: recover data */ >>>>>>> err = recover_data(sbi, &inode_list, &dir_list); >>>>>>> if (!err) >>>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Linux-f2fs-devel mailing list >>>>> Linux-f2fs-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >>>> >>>> . >>>> >> >> . >> > > > . >