From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6142B3176E4 for ; Thu, 18 Dec 2025 11:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766057039; cv=none; b=hAX6XvoBV+UIr/NzFS9lSOLq91MK7yuzAh6HOKcHQaH5Euwku31CjtKH80ju3cfNMCfd/eA8r+C24sOhJcPOfoJ47myrJ1OTdBh5JMA/ESCQM5hhjvQHmHuATtr2kY9m0tW+8qYk7tbfqci0i1Njo3AI3Flm0J7nuz55CgyWzBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766057039; c=relaxed/simple; bh=hs3jI0CO+N8F+Wozmcv4hy1NcL+3H2sHoU4lkDZA+qY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KlAhSVMb/5V2NSOkxnaJsCI7P4UmizkwFaCh3Uc5JG9z4yuXa5O0GNuP88sPDleaeTGGYjSTaXbhq6zyKiZluISvv/9/DfClLVcKKZAfAe5Sacin8xwbSWFxiHBrEeG/JUF4We0on8OapU7vEjj4h0SX+VV7+n7T691zIWQERBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KeSRamcO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZHi6riJX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KeSRamcO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZHi6riJX" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BI8obDK4147955 for ; Thu, 18 Dec 2025 11:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XM3PjRRkgJDLVtvgBlf1yGGi/oXyJmhRngXHmv4Ni6M=; b=KeSRamcO8HYzb+Jd 8DbYNGEtSh2mqQ2eIkctswsma5t61Lp7RqIvxNZPNCWCa9GWlyyIbx6LvXVB26RV x2GH4wxtBM+eu5MtYUy1N2FLrsQ5pYIM0sf0ZeRXFfAKE4N8CB+a07QIuMLY/JpW eWnOdXkjw0qubFHlLebkG73GKf7K5gfpAshYyGU5+9Ow2fE2DpnL9CZXgTejdPLI hw5i3MMvNGKL2ySdGFAlwk0l9+dDehUH9ToIyBZMiOYmivS2hapgNRp/XBGeGCWx qd4sVpFR+8lqBeqWvyhcLn9Q1S4fX3j6ngfIV12Udv445I+UJ6z5x0kwiVSEBme9 iWXp+w== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b40u7axjp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Dec 2025 11:23:54 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-88057e35c5bso1382856d6.3 for ; Thu, 18 Dec 2025 03:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766057034; x=1766661834; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XM3PjRRkgJDLVtvgBlf1yGGi/oXyJmhRngXHmv4Ni6M=; b=ZHi6riJXvxtai5P8MgfOuEM9tvHZ31NEtkiCsG4jq7JsRCaag0BfsbwEIW0T3gn4cn i44mOxTZgDgA+WSmZ8g5girW2pY6gxzbHb5ICTLwAJw6QXHfqZv+7Pb3RO7lOn58tOQ5 ejjaMd28A2Z+Qh8g8j0YGsLNJrLxsk4r7JeYHQCXlPeHuUMsSYlfE89luDrnOFoced3z rSDfYgakm2BAR+1otSFmastdKUEcRnl4grl58OU3PogeTik9Lza0S7Rpj8kEL6CklpZT F3tQlD2W2UyM2AlKORnurwueYBKn2zgt/6cV9DeBKfKeaeKFLdylREFCyCFSkwko89kp w05A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766057034; x=1766661834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XM3PjRRkgJDLVtvgBlf1yGGi/oXyJmhRngXHmv4Ni6M=; b=O3CahoDdW/uG+vM4W7Pg1LOPG9cfd4VoakKuUFe9feJ9ZPNEL/p6fCwBPjk+pdukab uIOLTmIsFUK1BwEwi9zGghKFKbBrQxeSGrX0PnUqAdyv7/AbL2wWOPltPsK4XTXbg1EX BuhgGcddjmSiqyYf+AKKGjnSvPf/3mghDSGnEGyKUTebytumQUbCp3cevuSexJn2y9y9 Q8zu/KZQN+FuVRINq41u6i4yReGsFJ+OxYS5DS33a7lq5vq5sq4hkIHXb7B81s9FYolv UesBudC5krZJcKXohhvKfhmMLLiuMLG0NRAp0pYOLyzdXWdjq0tGi09h38Siz7hOsS8B LOkQ== X-Forwarded-Encrypted: i=1; AJvYcCX+znvJkWqPvnlZu8ptj4jaUI9utDYVe216bUBJxu3QS/1fVC9gqk4bGd/5+L3CLIbK78WkHC553NNTx+c=@vger.kernel.org X-Gm-Message-State: AOJu0YyK339wbE8s3Tz1XFYtRJF0WykTWSWfWibIgHBEU+0yvk/5EqOM rY7uwuM1EOKmbulKFHtHrVKlUhsBLjF7LW3e+WxuT1s6VhG8s1fIUnu3uW7Z6veOAeXNuPEx86r pno/BKkSQtIv8qaLuZfEm6jh2voPqSNzgE6ekhrB5lAADv3LKSckDm/To1WQJafLNDm4= X-Gm-Gg: AY/fxX5D/DfyOfnYXvzJ7bQjSKWg5Dy9LVga9HMLINrJCuCdzSycEt3+2yL2MFJVj6g AWlUhKb7B+tcliDsp6raLtcoD8IYH7zXcqJiECl5khTcblTFQa8DtuR90T1ruHIbkIcfFFmTr4H 3xGnKqRV4O9vQ21T11Q6Z3en8pB96RmMl4jVtg/UHAYRIYSIUnEEDJ4p6WF9c64CYqH/P6PuXK2 SsMHHwgU3Pmd71lqqtnfqd2uQFxDI48kJGfTD/NjRd8geBBRgdyjy+AUlwtSMbAG8ig2bJ9x97B c05xy+3WOh7nlBZgmjuti27Nt7XGtW+tK6Onc4gs4vjw4q/cZMdXPeeeUvEjk+sH6vualWLOH+R 2xkZVtwvt0re8Jnk8iRRzmgXMt9JR23aS8UK0ap3VefYQb2UNUApoLwkkSzc5rr7MHA== X-Received: by 2002:a05:6214:2023:b0:882:63cf:3970 with SMTP id 6a1803df08f44-88c9770bd12mr18182396d6.1.1766057033627; Thu, 18 Dec 2025 03:23:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/tvDYCoy3mFqOPD7fGTgiVRBpPOULT1Lah31cAzxTWH9nDj15BUCPMDBDM0NtBT/HmoVqzg== X-Received: by 2002:a05:6214:2023:b0:882:63cf:3970 with SMTP id 6a1803df08f44-88c9770bd12mr18182046d6.1.1766057033159; Thu, 18 Dec 2025 03:23:53 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b585d1d61sm2335297a12.9.2025.12.18.03.23.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Dec 2025 03:23:52 -0800 (PST) Message-ID: <24f29ff0-99d0-4175-a6c9-f402ce99f645@oss.qualcomm.com> Date: Thu, 18 Dec 2025 12:23:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/mdp5: drop support for MSM8998, SDM630 and SDM660 To: Dmitry Baryshkov , Alexey Minnekhanov , "marijn.suijten@somainline.org" Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Sajna , barnabas.czeman@mainlining.org References: <20251211-mdp5-drop-dpu3-v1-1-0a0186d92757@oss.qualcomm.com> <8e1d33ff-d902-4ae9-9162-e00d17a5e6d1@postmarketos.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: tYiB7OePzi9VCa8BXWuJ2Zgf5oyZKW8e X-Authority-Analysis: v=2.4 cv=Z8Th3XRA c=1 sm=1 tr=0 ts=6943e44a cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=NEAV23lmAAAA:8 a=cLwkmEU5_4-cEt2YZAUA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: tYiB7OePzi9VCa8BXWuJ2Zgf5oyZKW8e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE4MDA5MyBTYWx0ZWRfX6G2mA5mgPZxG +kr8nIgS3T5HhX5ceuhX6ULNiXTKk9YVDyCeRGlgBVjQPUN/DYH/DOcoDMdIKjOjpSHrgyxxpWg 6Glihdp0ez8iOtphKLJ6doEgebDp6EibloMh2TVJQOv04mnxibcTScTGWRnpfVtkTmc1eOshNe0 65Np1DXEs/XnLrtRzxYSyRfJBeLOrlS+5HblZZiMSpXB/ngkgqqNln7q0iCJbi2aNsNJD3OIB9W KFe880fti4BKXJURDpJhtbPRFLPqYjM+9iKzG/Mx+UCRZzXPt7XycDsG/8nigVvJLu2SWNHT/iM Em8SFTq1DBI/q1yRpzobkOTAxFO23o61pfWft3+ykv+jM8uf+sTYih3qHQ/qphaJAUFgMcNwjnB /5I+s2oX/JDMKXNZfqvSOyg1SxRCiQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-18_01,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512180093 On 12/17/25 5:34 PM, Dmitry Baryshkov wrote: > On Wed, Dec 17, 2025 at 06:05:31PM +0300, Alexey Minnekhanov wrote: >> On 11.12.2025 04:25, Dmitry Baryshkov wrote: >>> Currently MDP5 3.x (MSM8998, SDM630 and SDM660) platforms are support >>> by both DPU and MDP5 drivers. Support for them in the DPU driver is >>> mature enough, so it's no longer sensible to keep them enabled in the >>> MDP5 driver. Not to mention that MSM8998 never used an MDP5 compatible >>> string. Drop support for the MDP5 3.x genration inside the MDP5 >>> driver and migrate those to the DPU driver only. >>> >>> Note: this will break if one uses the DT generated before v6.3 as they >>> had only the generic, "qcom,mdp5" compatible string for SDM630 and >>> SDM660. However granted that we had two LTS releases inbetween I don't >>> think it is an issue. >>> >> >> I've retested DPU driver on our downstream release based on 6.18 (by >> using msm.prefer_mdp5=false kernel cmdline parameter) on all devices >> at my disposal, and I can confirm DPU driver working fine an all SDM660, >> SDM636 ones, but not on SDM630. Some logs from sdm630-sony-nile-pioneer >> (Sony Xperia XA2): > > Unfortunately I only have SDM660 and video DSI usecase here. BTW: is > your SDM636 / SDM660 using CMD or video panel? > >> >> [ 2.356546] msm_dpu c901000.display-controller: bound c994000.dsi (ops >> dsi_ops [msm]) >> [ 2.357328] adreno 5000000.gpu: GPU speedbin fuse 146 (0x92), mapped to >> opp-supp-hw 0x4 >> [ 2.364802] msm_dpu c901000.display-controller: bound 5000000.gpu (ops >> a3xx_ops [msm]) >> [ 2.444649] [drm:dpu_kms_hw_init:1173] dpu hardware revision:0x30030000 >> [ 2.449793] [drm] Initialized msm 1.13.0 for c901000.display-controller >> on minor 1 >> ... >> [ 2.911900] [drm:_dpu_encoder_phys_cmd_wait_for_ctl_start:654] [dpu >> error]enc33 intf1 ctl start interrupt wait failed >> [ 2.911916] [drm:dpu_kms_wait_for_commit_done:525] [dpu error]wait for >> commit done returned -22 >> ... >> [ 3.176171] [drm:_dpu_encoder_phys_cmd_wait_for_ctl_start:654] [dpu >> error]enc33 intf1 ctl start interrupt wait failed >> [ 3.176367] [drm:dpu_kms_wait_for_commit_done:525] [dpu error]wait for >> commit done returned -22 >> >> Which results in horrendous ~3-5 fps in shell. >> >> The block "enc33 intf1 ctl start interrupt wait failed" + "wait for >> commit done returned -22" is repeated few times per second whenever >> the display is turned on, and stops when it's turned off. >> >> Meanwhile it is working fine using MDP5 driver (msm.prefer_mdp5=true). > > It's interesting. Would you please capture the devcoredump for the > platform? There will be a lot of blocks, I'm interested in INTF_1, CTL > and top_0. > > Also, as a debugging check, would you mind patching > dpu_encoder_phys_cmd_wait_for_commit_done() so that it always calls > dpu_encoder_phys_cmd_wait_for_tx_complete()? I will check if there are > any differences for CTL_START and similar registers, but it will take > some time. > >> Well, as fine as possible considering [1], using several FD_MESA_DEBUG >> tricks to work around GPU issues. >> >> P.S. I have not yet tested MSM8998, but I can try if required > > As far as I remember, MDP5 on MSM8998 has never been wired (as in never > committed to the DTSI). Angelo has enabled and Freebox people have > tested DPU on MSM8998, but I think it was limited to video / HDMI > usecases. I think we poked at both, back in the day (tm) and DPU worked on msm8998- sony-maple (sharp,ls055d1sx04 cmd mode panel) with the funny CMD mode hack (due to a register field not existing on <845?) https://github.com/SoMainline/linux/commit/14e0517e2fd5eee116a32db624b09856c60fa022 FYI panel wiring: https://github.com/SoMainline/linux/commit/88f276e81cea0f7496d3f92cd731f27615cfa703 +Marijn may know more Konrad