From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 707343C4B76 for ; Fri, 22 May 2026 09:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443297; cv=none; b=H57fMRJGgRV4HAlDB4ZwwQEYwem+8aQM6vCCc2swb5ql53Xhtp998igarZf9w2/X7xc0LeCnfRDa+N9V1JMVAtVTUiZBtGB/uVFp4QNrtaXvkXCNcVT0KVa8mFxrABQBsJ/9W7eKJyTmo7KcKjPAjt14I8/RZrYVpW7sfrv2UgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443297; c=relaxed/simple; bh=fnA6TuXjxoD/qV1B06x19WzNk1sYIqRGpslMrz4epBQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iCRxbagtwvXu1E2c5I6LbU5pGxbXhjOvlB1kBSSNY6Dsj4wZzDCFbQe2N96Aq+02vVrj/8tzEhsq99KSmotLEDrZyYfzhSlOzK1cJ3oStfmrTBq3SbUIuzUi0K4h8ENq8NVF2TBWk+7dgCqkmtl7Xvae2tLM/LXwbjIAERBdcJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KyS96uHt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FWow4lY/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KyS96uHt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FWow4lY/" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M8hERT3532312 for ; Fri, 22 May 2026 09:48:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nxeYY6u/8efyIE6Ut3SOnhqR/Qrg6Pv6nhSejVY4/Uw=; b=KyS96uHtCkpE5n1Z uc5oOH2s/296hUuAs+RcnFf5CRcGGR0W1W/RqqXGXFjFSrCdXpqIS9TQpFRfaeu2 M7avenXbaIkD36PAsueW5xEC8uNDvHthDDNVtLilgy+0nWZzwuVz666xJIK/j/Ju Yi8+/sVa5vCxoSxOIrHUlwGypi5MT08n/aXvSeBo8kr0wYhmiE1/vfqg0nZKrcwg iAcRaxhkUC/exClJOVte+fVM0XwOuCpagD46sVONTbrrOm0HxydVxvmc5Csfdy9J FVfvpNuMDJCZOAvRJ+3DiSFZBu9muHQ0KjxjoaGirewuTp69oeOZculMhDZjVrS6 0/QqWA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea39gvfbb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 09:48:10 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-516d1b82fd1so1795631cf.3 for ; Fri, 22 May 2026 02:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779443290; x=1780048090; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nxeYY6u/8efyIE6Ut3SOnhqR/Qrg6Pv6nhSejVY4/Uw=; b=FWow4lY/160LIc+An86OAeZoQBZq5ytgpJNyeF69bMPhbCb7Hsi33CavswpILh3qVc 7vzvkC9EbNMra2mVPyD5QhNm9ZfJrfs0tmOA+Pc/EI3cqA1VQNdzhr7RglgB/P2AcoR8 85O6IqdHrLCKS3/wKuvB12quJa4zlG6qmQr0MnPJ12Yoab+QVvDhAQuTQ1SIqcFkQFmY B8jB3+cPQroCcMEt2sBD+ByjAtUTfxg9gfQugOUzf1s9ToVMoFXc46Twe/DRIbU5Nd/x jpk2La1i9VEmJ2ocrErDwAmDfs2JoJsGujV+oYhBJ9O30CwG4XguJcAtsFfSCcY26fT1 hdUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779443290; x=1780048090; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nxeYY6u/8efyIE6Ut3SOnhqR/Qrg6Pv6nhSejVY4/Uw=; b=WcXqR34fOdL2LPZbOQdjXwVfnlofynWis47N6iBVz6H31WfBrD1Qoxe+4mmG3/ew3x dnIOJ1sZoCiLertI3DEGVhDUBMAOZLax5IXbpjjesLLKOiX4ewPjzThIg+h3yW1zZPhl i0Hdt3jXTp2jMtvApwOImK5KNExGgdq5JBvMAWuQ48YxH3KLYzwc1R5qOnkMzFo3M7kF 6UyAp514HWlZQNlrEyq1Tw8L4CH0O1OcGGJ5U5Bj7ysr4uchLV1k3USNfRZ+gdUChOVb VKcSlWEKdXf4xNUSC3QBtLsa6NO7OXljSvDcqQjJIPm0akTG0/buDUP5iaQc6tz9hPoD lgPA== X-Forwarded-Encrypted: i=1; AFNElJ9LaVCya19fECbireR+6DMqW2mbl6ugE+NHhXE+tG8CAYg0m5Enk/8DfRSvBVsJAWZqlEp1QU14eAmWHDs=@vger.kernel.org X-Gm-Message-State: AOJu0YyAqKtQ1cxQK3qpq6KBMxR4+zQKAWuMtGJrFe4snLMosyEeaD18 3pwSlocEWgNRgM3Yw4fnXkZnvEC7VXBR/WXxNFgRhQJPAjHynpmWCLQFewQvi9gXxYbxGhTbJbs AfgJpEb8tHRa9xL/Qlih+jnrTCdzuAoht4wI7bhELovzlVQyJvXNCuLY0rY5Off1ND5HQAchufr I= X-Gm-Gg: Acq92OH9OR/23flx005U9+wjupHD740IRqw4ZvWQaeOgaGGGA01CdE4mWjB/XiK0Hvf dJmgnsSRFd3O7mKTKqngu/NFgksr65hZoUTKqQdb+WGflkVSB3t6GZrFjOB5oZ8sb8CZAJ9YnS+ ejEWvR+kFMuc28Mww8AYFhXwaC0Z5VJVvN7/poBQSSLDDoMUoZ8CAuNclVJl77yLS1Wt/0GNtJr +R2GTLfVqIFpfP2dAH8akNrqMo2eIbXtF+or9fCz6aPfuph1dW2XoNOMYrE2TH0BxrIUiahOBYC jzHDkBHglvPHpKVcl4MPZIEUaZqGi23ixl4HSCrO8ycIDTXNtqR4YBZOU5KahTBMWgC/mKLT/18 2DQDLz5xoGWcVi848OQUUgNFB4y8gj0kC6rf9LvkyWFdZPg== X-Received: by 2002:a05:622a:6116:b0:50d:9138:3322 with SMTP id d75a77b69052e-516d43f5402mr26315371cf.7.1779443289731; Fri, 22 May 2026 02:48:09 -0700 (PDT) X-Received: by 2002:a05:622a:6116:b0:50d:9138:3322 with SMTP id d75a77b69052e-516d43f5402mr26315241cf.7.1779443289307; Fri, 22 May 2026 02:48:09 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc3652b34sm36909566b.28.2026.05.22.02.48.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 02:48:08 -0700 (PDT) Message-ID: <24f84ae8-6099-43a1-91a9-b50a0aaeb3e1@oss.qualcomm.com> Date: Fri, 22 May 2026 11:48:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: monaco-arduino-monza: Add QCA2066 M.2 WiFi/BT support To: Loic Poulain , Dmitry Baryshkov Cc: Manivannan Sadhasivam , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org References: <20260520-monza-wireless-v1-0-9f6942310653@oss.qualcomm.com> <20260520-monza-wireless-v1-3-9f6942310653@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Yr8/gYYX c=1 sm=1 tr=0 ts=6a10265a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=aCkQYJryizutyd-nL94A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: 6oPi4WBDLMWNMzl7txmhye-6FkxPNFn3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA5NyBTYWx0ZWRfXx2mrwTlz/RXt 5e2MsNPB+gl+iV/MlURMo0IT/PB3REZgJBuLHgYOw/a86LhBsz4wehf8g077EA2QFK71jkYMHFQ RIDjk3W7iSc3KxwPj1bxXMWJsGKwKEU0mLDhcMZd0gA1GaDPZrEmVGA2ywBwDzP1xnhb/c+RFsA 5/Tl73waAZhfrZdqndEYBa7POvIJ+11a+rhTMnbRzz1VgJyZ1LRPIJLnRmRAl+Y28VTIhnJiL4X CNF88uqW7ZgyxOa3rYoOJkd8/qlaXVWnzPNqXNm6x4uSt0TZH05q0ay+fhkThO9ErEgppVOEt4i nMsm6sxMU7Xqf7G35bkAHhguVzn87bAknweY4lBvlm3JRFui2IPnlU+GfMI1SOhGuV/chHZu93x PzO8z9kTSPjNWCV2NO/iG2+xLqOY6KDXK8b1/+4BQ5T4yPVFca/BXZfmUiljTKekeOVwVPmyfK9 /mmSlIo2b6cG8IFokKA== X-Proofpoint-GUID: 6oPi4WBDLMWNMzl7txmhye-6FkxPNFn3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220097 On 5/20/26 4:41 PM, Loic Poulain wrote: > On Wed, May 20, 2026 at 4:36 PM Dmitry Baryshkov > wrote: >> >> On Wed, May 20, 2026 at 04:29:40PM +0200, Loic Poulain wrote: >>> On Wed, May 20, 2026 at 2:34 PM Dmitry Baryshkov >>> wrote: >>>> >>>> On Wed, May 20, 2026 at 01:01:44PM +0200, Loic Poulain wrote: >>>>> Add support for the QCA2066 (QCNFA765) WiFi/Bluetooth module on the >>>>> Arduino VENTUNO Q board. The module is interfaced via LGA and is >>>>> compatible with the M.2 Key E. >>>>> >>>>> Add wireless-lga-connector node using pcie-m2-e-connector binding, >>>>> connecting PCIe port 0 to the WiFi interface and UART10 port 3 to >>>>> the Bluetooth interface. >>>>> >>>>> Add pcie@1,0 downstream port node with pciclass,0604 compatible so >>>>> the pci-pwrctrl driver can acquire the power sequencer and enable >>>>> the M.2 slot before PCIe enumeration. >>>>> >>>>> Add nfa725b_default_state pinctrl for the W_DISABLE1/2 GPIOs >>>>> (gpio56/gpio55) used by the power sequencer. >>>>> >>>>> Signed-off-by: Loic Poulain >>>>> --- >>>>> arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 65 +++++++++++++++++++++++ >>>>> 1 file changed, 65 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts >>>>> index 93ed575817af1c5e903662c209ead629fe202ee2..6fcad77f320cb82eccb6f07244d185abfb1976d9 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts >>>>> @@ -154,6 +154,39 @@ vreg_nvme: regulator-3p3-m2 { >>>>> enable-active-high; >>>>> startup-delay-us = <20000>; >>>>> }; >>>>> + >>>>> + wireless-lga-connector { >>>>> + compatible = "pcie-m2-e-connector"; >>>> >>>> I think it was discussed that LGA can't be an actual M.2 E-key >>>> connector. >>> >>> I am not sure I followed this discussion. Do you mean that I should >>> introduce a dedicated LGA/vendor-compatible string in the compatible >>> list of the pcie-m2-e-connector binding, or that LGA-based designs >>> should not be described using the pcie-m2-e-connector binding (graph >>> representation)? >> >> I think, it should be a separate, vendor-specific compat (maybe using >> m2-e as a fallback). > > ok, understood. Oh, I reviewed this before looking at this discussion.. yeah Dmitry's suggestion is good Konrad