From: Arnd Bergmann <arnd@arndb.de>
To: Ray Jui <rjui@broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support
Date: Fri, 27 Nov 2015 21:22:21 +0100 [thread overview]
Message-ID: <2502233.oJMLi3GpfH@wuerfel> (raw)
In-Reply-To: <1448645868-5730-3-git-send-email-rjui@broadcom.com>
On Friday 27 November 2015 09:37:45 Ray Jui wrote:
>
> +static const struct of_device_id iproc_pcie_of_match_table[] = {
> + {
> + .compatible = "brcm,iproc-pcie",
> + .data = (int *)IPROC_PCIE_PAXB,
> + }, {
> + .compatible = "brcm,iproc-pcie-paxc",
> + .data = (int *)IPROC_PCIE_PAXC,
> + },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, iproc_pcie_of_match_table);
You seem to only need the identifiers in order to set a single
pointer, so just point to that array directly. Alternatively,
do the more common thing and point to a structure of function
pointers and have different implementations of the low-level
access functions there.
Arnd
next prev parent reply other threads:[~2015-11-27 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 17:37 [PATCH v4 0/5] Add iProc PCIe PAXC and MSI support Ray Jui
2015-11-27 17:37 ` [PATCH v4 1/5] PCI: iproc: Update iProc PCIe device tree binding Ray Jui
2015-11-27 17:37 ` [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Ray Jui
2015-11-27 20:22 ` Arnd Bergmann [this message]
2015-11-27 20:56 ` Ray Jui
2015-11-27 21:11 ` Arnd Bergmann
2015-11-27 21:18 ` Ray Jui
2015-11-27 17:37 ` [PATCH v4 3/5] PCI: iproc: Add iProc PCIe MSI device tree binding Ray Jui
2015-11-27 17:37 ` [PATCH v4 4/5] PCI: iproc: Add iProc PCIe MSI support Ray Jui
2015-12-02 14:30 ` Hauke Mehrtens
2015-12-02 17:19 ` Ray Jui
2015-11-27 17:37 ` [PATCH v4 5/5] ARM: dts: Enable MSI support for Broadcom Cygnus Ray Jui
2015-12-02 17:23 ` [PATCH v4 0/5] Add iProc PCIe PAXC and MSI support Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2502233.oJMLi3GpfH@wuerfel \
--to=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rjui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome