From: YueHaibing <yuehaibing@huawei.com>
To: Paolo Abeni <pabeni@redhat.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <arvid.brodin@alten.se>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: hsr: Fix potential use-after-free
Date: Fri, 25 Nov 2022 15:53:13 +0800 [thread overview]
Message-ID: <250b2e18-13bd-b0d5-8117-112ffc42b55a@huawei.com> (raw)
In-Reply-To: <cf297dd17750f988128df88c824f956f2a4bb719.camel@redhat.com>
On 2022/11/24 16:53, Paolo Abeni wrote:
> Hello,
>
> On Wed, 2022-11-23 at 14:30 +0800, YueHaibing wrote:
>> The skb is delivered to netif_rx() which may free it, after calling this,
>> dereferencing skb may trigger use-after-free.
>>
>> Fixes: f266a683a480 ("net/hsr: Better frame dispatch")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> The code looks good, but the above is not the commit introducing the
> issue, it just move the netif_rx() and later skb access from somewhere
> else.
>
> Please go deeper in git history and find the change that originated the> issue.
Ok, will dig it.
>
> Thanks,
>
> Paolo
>
> .
>
prev parent reply other threads:[~2022-11-25 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 6:30 YueHaibing
2022-11-24 8:53 ` Paolo Abeni
2022-11-25 7:53 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=250b2e18-13bd-b0d5-8117-112ffc42b55a@huawei.com \
--to=yuehaibing@huawei.com \
--cc=arvid.brodin@alten.se \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®