mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Richard Alpe <richard@bit42.se>,
	srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	niklas.soderlund+renesas@ragnatech.se
Subject: Re: [PATCH v3 1/2] dt-bindings: nvmem: Add nxp,qoriq-efuse
Date: Thu, 30 Mar 2023 10:00:40 +0200	[thread overview]
Message-ID: <250dd9d8-7592-6ebd-e63f-98ae5aad542c@linaro.org> (raw)
In-Reply-To: <20230328082701.2569114-1-richard@bit42.se>

On 28/03/2023 10:27, Richard Alpe wrote:
> Add a schema for the NVMEM eFuse (SFP) layout on the NXP QorIQ SOC.
> 
> Signed-off-by: Richard Alpe <richard@bit42.se>
> ---
>  .../bindings/nvmem/nxp,qoriq-efuse.yaml       | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/nvmem/nxp,qoriq-efuse.yaml

Filename matching compatible.
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/nxp,qoriq-efuse.yaml b/Documentation/devicetree/bindings/nvmem/nxp,qoriq-efuse.yaml
> new file mode 100644
> index 000000000000..e1d4d3849519
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/nxp,qoriq-efuse.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/nxp,qoriq-efuse.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP QorIQ eFuse support
> +
> +maintainers:
> +  - Richard Alpe <richard@bit42.se>
> +
> +description: |

Do not need '|'.

> +  Read support for the eFuses (SFP) on NXP QorIQ series SoC's.
> +
> +allOf:
> +  - $ref: "nvmem.yaml#"

Drop quotes.

> +
> +properties:
> +  compatible:
> +    oneOf:

Drop oneOf, no need for it. You can put description as comment.

> +      - description: Trust architecture 2.0
> +        items:

One items, so no need for "items:"

> +          - const: fsl,t1023-sfp
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    efuse@e8000 {
> +        compatible = "fsl,t1023-sfp";
> +        reg = <0xe8000 0x1000>;
> +    };
> +...

Best regards,
Krzysztof


      parent reply	other threads:[~2023-03-30  8:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  8:27 Richard Alpe
2023-03-28  8:27 ` [PATCH v3 2/2] nvmem: add new NXP QorIQ eFuse driver Richard Alpe
2023-03-30  8:00 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=250dd9d8-7592-6ebd-e63f-98ae5aad542c@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=richard@bit42.se \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®