From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D13361D5AD4 for ; Mon, 22 Jun 2026 07:45:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782114325; cv=none; b=g26cyiX40r6G095/FCUQxCgNOizgKc9/3qzg1iXHTEQ0vP2aj/yaDSMB3+7Bt8qhDL//M9ec3NKYemts8yKMlk2oaKIDujHIJhZBzJ99Jkxo+za7moa7tOdfAH9i0/QG2/mvfyD9cPV+Fjw+SpfWKjEVHAi3U+u9jOfwEkTr4IU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782114325; c=relaxed/simple; bh=IkTPCHvEioAxfxsxs7ThkxHSAlmvNwLjgp44PquHBQ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F3BCXRAiZstx7MMQbLf5WOfcErAnNgV6mrx418FKWgBkIRUz1haFoXy0Zy+Dn5Xso8e+MsLKXJurrdMil+FCg0m2ZU3AOuTLkr7/7F/f8CHNaSGoUQebCKXHvK30ocuG00zI7mIV0ZTuH9/WqOLlOgbcmvJ9YgsceZnKPyw87iI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=EQofUDfM; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="EQofUDfM" Received: from [192.168.88.20] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2047E1E6; Mon, 22 Jun 2026 09:44:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782114283; bh=IkTPCHvEioAxfxsxs7ThkxHSAlmvNwLjgp44PquHBQ4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EQofUDfMG6gszVwnDP+Jsvb5vJrKsPutcRFm4tPP7I65STlFhtfQUOyLXhBrsWVVc hLxXUua1NGJD9zJMRa1xxYSIvd4ul3tf+icIpclAOl2sjWJiOwf5yt1jjdj0iNLV8t IStb4/Pwge9/5zb3xHaL9izot6OJZtYn238cpok8= Message-ID: <25115d05-5868-45d5-9110-695347948a1f@ideasonboard.com> Date: Mon, 22 Jun 2026 10:45:17 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/13] drm/bridge: tc358762: Drop SPICMR write To: Andreas Kemnade Cc: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> <20260513-tc358762-fixes-v3-5-6698b55008b9@ideasonboard.com> <20260619082350.2ebc0cf7@kemnade.info> <20260621084150.6ea494ff@kemnade.info> From: Tomi Valkeinen Content-Language: en-US In-Reply-To: <20260621084150.6ea494ff@kemnade.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 21/06/2026 09:41, Andreas Kemnade wrote: > On Fri, 19 Jun 2026 08:23:50 +0200 > Andreas Kemnade wrote: > >> On Wed, 13 May 2026 16:10:14 +0300 >> Tomi Valkeinen wrote: >> >>> Drop write to SPICMR. It's unclear why the write is there, as SPI is not >>> supported in the driver, and it's mostly just writing zeroes to already >>> zero fields (reset defaults). None of the zero bits written disable >>> anything wrt. SPI. >>> >>> Signed-off-by: Tomi Valkeinen >> >> Comparing it with something out of tree where SPI is apparently working. >> It does not touch SPIMR, >> > ok, looking what that code really does, it sets bit 1 called SPI_SEL_CS0, > apparently in that register. But that belongs into an spi_init function. Sorry, what sets bit 1? The write removed here just writes zeroes to a register that's all zero by default, so it's basically a no-op unless someone else has touched the register. And as SPI is not supported in the driver, I think it's better to drop the write to not give any false ideas of SPI support. Tomi