From: Jiri Slaby <jirislaby@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] tty: serial: samsung: constify UART name
Date: Mon, 7 Mar 2022 07:36:27 +0100 [thread overview]
Message-ID: <25128bad-08a6-83a9-b554-ab32869538e3@kernel.org> (raw)
In-Reply-To: <20220304080348.218581-4-krzysztof.kozlowski@canonical.com>
On 04. 03. 22, 9:03, Krzysztof Kozlowski wrote:
> The UART name from driver data holds only string literals.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/samsung_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 0b4f40044e87..279c413f2300 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -63,7 +63,7 @@ enum s3c24xx_port_type {
> };
>
> struct s3c24xx_uart_info {
> - char *name;
> + const char *name;
> enum s3c24xx_port_type type;
> unsigned int port_type;
> unsigned int fifosize;
--
js
suse labs
next prev parent reply other threads:[~2022-03-07 6:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 8:03 [PATCH 1/7] tty: serial: samsung: embed s3c24xx_uart_info in parent structure Krzysztof Kozlowski
2022-03-04 8:03 ` [PATCH 2/7] tty: serial: samsung: embed s3c2410_uartcfg " Krzysztof Kozlowski
2022-03-07 6:31 ` Jiri Slaby
2022-03-04 8:03 ` [PATCH 3/7] tty: serial: samsung: constify s3c24xx_serial_drv_data Krzysztof Kozlowski
2022-03-07 6:36 ` Jiri Slaby
2022-03-07 7:48 ` Krzysztof Kozlowski
2022-03-04 8:03 ` [PATCH 4/7] tty: serial: samsung: constify UART name Krzysztof Kozlowski
2022-03-07 6:36 ` Jiri Slaby [this message]
2022-03-04 8:03 ` [PATCH 5/7] tty: serial: samsung: constify s3c24xx_serial_drv_data members Krzysztof Kozlowski
2022-03-07 6:38 ` Jiri Slaby
2022-03-07 7:49 ` Krzysztof Kozlowski
2022-03-04 8:03 ` [PATCH 6/7] tty: serial: samsung: constify variables and pointers Krzysztof Kozlowski
2022-03-07 6:41 ` Jiri Slaby
2022-03-04 8:03 ` [PATCH 7/7] tty: serial: samsung: simplify getting OF match data Krzysztof Kozlowski
2022-03-07 6:30 ` [PATCH 1/7] tty: serial: samsung: embed s3c24xx_uart_info in parent structure Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25128bad-08a6-83a9-b554-ab32869538e3@kernel.org \
--to=jirislaby@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®