From: Oliver Neukum <oneukum@suse.com>
To: Deepak R Varma <drv@mailo.com>, Ali Akcaagac <aliakc@web.de>,
Jamie Lenehan <lenehan@twibble.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
dc395x@twibble.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR
Date: Wed, 8 Feb 2023 10:26:58 +0100 [thread overview]
Message-ID: <251560a0-489f-eb54-d039-5270436117b9@suse.com> (raw)
In-Reply-To: <Y+IQoG3aYdTfMStu@ubun2204.myguest.virtualbox.org>
On 07.02.23 09:49, Deepak R Varma wrote:
> When adding two bit-field mask values, an OR operation offers higher
> performance over an arithmetic operation.
Hi,
I am sorry, but this change log makes no sense. These are constants.
The compiler turns that into one value in any case.
If you do a clean up, say so.
Regards
Oliver
prev parent reply other threads:[~2023-02-08 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 8:49 Deepak R Varma
[not found] ` <02269e84-5ca8-f150-b225-c4d8898624ec@neukum.org>
2023-02-07 17:50 ` Deepak R Varma
2023-02-08 9:26 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=251560a0-489f-eb54-d039-5270436117b9@suse.com \
--to=oneukum@suse.com \
--cc=aliakc@web.de \
--cc=dc395x@twibble.org \
--cc=drv@mailo.com \
--cc=jejb@linux.ibm.com \
--cc=kumarpraveen@linux.microsoft.com \
--cc=lenehan@twibble.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®