mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolai Buchwitz <nb@tipi-net.de>
To: Fidelio Lawson <lawson.fidelio@gmail.com>
Cc: Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Marek Vasut <marex@denx.de>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Simon Horman <horms@kernel.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Tristram Ha <Tristram.Ha@microchip.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Fidelio Lawson <fidelio.lawson@exotec.com>,
	Marek Vasut <marex@nabladev.com>
Subject: Re: [PATCH net-next v8 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables
Date: Mon, 01 Jun 2026 15:25:59 +0200	[thread overview]
Message-ID: <2516d18e2acb66f9f13986506f168803@tipi-net.de> (raw)
In-Reply-To: <20260601-ksz87xx_errata_low_loss_connections-v8-3-cfa102cf62c0@exotec.com>

Hi Fidelio

On 1.6.2026 13:54, Fidelio Lawson wrote:
> Add support for the KSZ87xx low-loss cable PHY tunables in the Micrel
> PHY driver by implementing get_tunable and set_tunable callbacks.
> 
> These callbacks expose vendor-specific PHY tunables used to control the
> KSZ87xx embedded PHY receiver behavior when operating with short or
> low-loss Ethernet cables. The tunables provide:
> 
> - a boolean short-cable preset applying known good settings;
> - an integer LPF bandwidth control;
> - an integer DSP EQ initial value control.
> 
> The Micrel PHY driver forwards these tunables via standard phy_read() /
> phy_write() operations, which are virtualized by the KSZ8 DSA driver 
> and
> translated into the appropriate indirect switch register accesses.
> 
> Reviewed-by: Marek Vasut <marex@nabladev.com>
> Signed-off-by: Fidelio Lawson <fidelio.lawson@exotec.com>
> ---

> [...]

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks
Nicolai

      reply	other threads:[~2026-06-01 13:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 11:54 [PATCH net-next v8 0/3] ksz87xx: add support for low-loss cable equalizer errata Fidelio Lawson
2026-06-01 11:54 ` [PATCH net-next v8 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Fidelio Lawson
2026-06-01 13:40   ` Nicolai Buchwitz
2026-06-01 13:44   ` Marek Vasut
2026-06-01 11:54 ` [PATCH net-next v8 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Fidelio Lawson
2026-06-01 13:26   ` Nicolai Buchwitz
2026-06-01 11:54 ` [PATCH net-next v8 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Fidelio Lawson
2026-06-01 13:25   ` Nicolai Buchwitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2516d18e2acb66f9f13986506f168803@tipi-net.de \
    --to=nb@tipi-net.de \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fidelio.lawson@exotec.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lawson.fidelio@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marex@denx.de \
    --cc=marex@nabladev.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®