From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932855AbbJPUfn (ORCPT ); Fri, 16 Oct 2015 16:35:43 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:58616 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932370AbbJPUfk (ORCPT ); Fri, 16 Oct 2015 16:35:40 -0400 From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] [media] cobalt: add VIDEO_V4L2_SUBDEV_API dependency Date: Fri, 16 Oct 2015 22:35:33 +0200 Message-ID: <25194020.Fs8hi1GXzI@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:YDOm3rixj7edMzzgNp2wgs2ZQyyQs1oIzAqlZNfE0pEcxXlR9Tf 20Fj5JaBYOnU6myey8wd+mEuKspTqA/I4b+hDaeOYuGMx0lFO/Lc/LpN1d4YvkOdUq9QMp6 IYE9eyg7TOAQRoiO/bY33tzyLT+2K82nUCAB7KEvEmosID+MTbX1kIw3sgVYmBMam9zOR9O xnJqtZBflBHXRUc0hzh9Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:UOkAfN/yleY=:2H8hD/u4WbYCgzZ0oYCNp4 JHP3dP8535lxsjDZhcTqFROeymH4qNSM349yTjRmLpYp837yJfvVx+woTCTQGlV3plSWZQUdc 8LiAKHhszyW7Y21HnGX2PsSZcG7VesJBTa0SWh+hbonpDkaXV/U7cDezmfEWoRsJNRUdH9dfm zzznn6KNTdg4oTqSvva/PkEh4mN86LYvl/gv4PT/IW1rNSdVUHda074oIWQzHPCxi1QxnnqR/ epe4Q9+gP7lJyNtgBr0gt15B3kX9f0IkwA4imxLtM9xJ4PGCwNz2BDuePpYyRY077k2e9PyqF s2FuDIWnmxq5OovhupsEMrkkyRg8orfh8wUSnAlALCj0YIy0jqRFP9w0ZUuqxTVfbIMtwMl8E aTZPNBLsk2URvg1HDKSukOrtlqaa7NdLTywVMFwSaq9jZBLJ28eIvnshuE+OtCm3JLsCBNOTr UycLhjQadGUL/Pg/Tqy9oytRukBkKH6QFeYTAOSLRHNNRax1q3mSs7jtAe6QbLpyNl42rVQQJ 0snJNj14pvdPXJ1FxAzbcfxHtNLMgVZzNXCyS/4Kt8VGib8dgX6kTb4EqYLhLqLDfbCFtJXoV ZXakvkMYouOAf5NwNMLOA3KCnElvGuJ9IVc/S5kwkONJfZINmK6UekEoVqVjzIud4fQetDEWF U+gnRPN1pnglqB7sieO8wpNiFNesv5PySkYDjMYqlHcZCooRhTrRImIgKAYpsdn8lrOfjugBo 6hzgJu8q3g64WwPA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cobalt driver uses various encoders that require the VIDEO_V4L2_SUBDEV_API code, but it does not have the dependency itself, so we get a build error when it's not enabled: warning: (VIDEO_COBALT) selects VIDEO_ADV7511 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API) warning: (VIDEO_COBALT) selects VIDEO_ADV7604 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && (GPIOLIB || COMPILE_TEST)) warning: (VIDEO_COBALT) selects VIDEO_ADV7842 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API) drivers/media/i2c/adv7604.c: In function 'adv76xx_get_format': drivers/media/i2c/adv7604.c:1878:9: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration] This adds an explicit dependency. Signed-off-by: Arnd Bergmann --- Found on ARM randconfig builds diff --git a/drivers/media/pci/cobalt/Kconfig b/drivers/media/pci/cobalt/Kconfig index 1f88ccc174da..a7f750520757 100644 --- a/drivers/media/pci/cobalt/Kconfig +++ b/drivers/media/pci/cobalt/Kconfig @@ -1,6 +1,7 @@ config VIDEO_COBALT tristate "Cisco Cobalt support" depends on VIDEO_V4L2 && I2C && MEDIA_CONTROLLER + depends on VIDEO_V4L2_SUBDEV_API depends on PCI_MSI && MTD_COMPLEX_MAPPINGS depends on GPIOLIB || COMPILE_TEST depends on SND