From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbdBHKiq (ORCPT ); Wed, 8 Feb 2017 05:38:46 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:42498 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbdBHKi0 (ORCPT ); Wed, 8 Feb 2017 05:38:26 -0500 X-AuditID: b6c32a35-f79166d000001a4b-11-589af22e556f From: Bartlomiej Zolnierkiewicz To: Arvind Yadav Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] omapfb: dss: Handle return error in dss_init_ports. Date: Wed, 08 Feb 2017 11:25:47 +0100 Message-id: <25198769.WjcufK8OeX@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsWy7bCmvq7ep1kRBlsvqlpc613IbHGi7wOr xeVdc9gsZi/pZ7FYP/8WmwOrx85Zd9k9jt/YzuTxeZNcAHMUl01Kak5mWWqRvl0CV8auH+uY C6ZzVBw/pNzAeImti5GTQ0LARGLzkjlMELaYxIV764HiXBxCAjsYJd4svssK4bQzSaz7/Y0V pmPChG0sEIk5jBKTv02DavnKKHHg3Tt2kCo2ASuJie2rGEFsEQEdiU0zf4PZzAJFEg1rT4HZ wgIeErOPnQWaysHBIqAq8bfBAiTMK6AlcXXzMbCTRAW8JLbsawezOQVsJS5N+s0EUSMo8WPy PRaIkfIS+/ZPZYWwdSTOHlvHCHKPhEAzu8TDOfeZQOZLCMhKbDrADPGAi8Tm5W+gXhaWeHV8 CzuELS2x6t8tqPh0RontvyUg5mxmlFi1ewJUkbXE4eMXoZbxSbz72sMKMZ9XoqNNCKLEQ+Lg 2e9QcxwlJs24zQQJn42MEr1HT7JOYJSfheSHWUh+mIXkhwWMzKsYxVILinPTU4sNCwz1ihNz i0vz0vWS83M3MYJThZbpDsYp53wOMQpwMCrx8GrEzooQYk0sK67MPcQowcGsJML76A1QiDcl sbIqtSg/vqg0J7X4EKM0B4uSOC+rwcQIIYH0xJLU7NTUgtQimCwTB6dUA2PvsZiZnGdPlc1Z tH7z18naV0/bM7kqM731fjH/865XqwWi715aP+PFsuI/Vlukzk7JvXfv6649fQEv7j8rUXZf rRZ+X9RfM6I9nGFCvxdntj7XDguJhb8WfP41K2vVpC/Z6x/O5dknf2Pf4+CDdive35oecD90 3rfjT+11V1od079yQPKB0uKO3UosxRmJhlrMRcWJAKkcPfkRAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jQV29T7MiDJZ9ELO41ruQ2eJE3wdW i8u75rBZzF7Sz2Kxfv4tNgdWj52z7rJ7HL+xncnj8ya5AOYoN5uM1MSU1CKF1Lzk/JTMvHRb pdAQN10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgHuAcr6dsluGXs+rGOuWA6R8XxQ8oN jJfYuhg5OSQETCQmTNjGAmGLSVy4tx4sLiQwi1Gi64tAFyMXkP2VUeLu7F4mkASbgJXExPZV jCC2iICOxKaZv8FsZoEiiQ3TzoE1Cwt4SMw+dpa1i5GDg0VAVeJvgwVImFdAS+Lq5mNgY0QF vCS27GsHszkFbCUuTfrNBLFrI6PEw2XPWCEaBCV+TL7HAjFfXmLf/qmsELaWxPqdx5kmMAJd iVA2C0nZLCRlCxiZVzFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIER84zqR2MB3e5H2IU 4GBU4uH1qJwVIcSaWFZcmXuIUYKDWUmE99EboBBvSmJlVWpRfnxRaU5q8SFGU6AHJzJLiSbn A6M6ryTe0MTcxNzYwMLc0tLESEmct3H2s3AhgfTEktTs1NSC1CKYPiYOTqkGxlbB95kPPn/7 t9R19oG/fXF7gi5IldxIz9p2dv4FQ0Vl4xwenhlCRdKLhAQ+L1PxyH5rlZ0fNmtZggXDlMyD Wv0VRcs2xTIyyed6bTmoPMU6Uv3Zjb4bNvVKXl5bn3WJJm7K31ffZOtSHPqNi2El9y3Oz1b/ z22tOrLiumzFe6trZU5f7t4zUGIpzkg01GIuKk4EAI/6VgiyAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170208102550epcas1p154a081a26a1c9fd32a316b120fa14616 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170203122444epcas2p3e0d5ed32cac85fd86d900a62dbeb03a4 X-RootMTR: 20170203122444epcas2p3e0d5ed32cac85fd86d900a62dbeb03a4 References: <15170308.DWakhCLKvX@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, February 07, 2017 05:41:37 PM Arvind Yadav wrote: > Hi, > > In dss_init_ports, There is no need to add dss_uninit_ports before > returning. > Because it's already take care in dss_bind. dss_bind is handling > dss_uninit_ports in error path. It doesn't handle cleanup of partially initialized ports, please look at the code: ... r = dss_init_ports(pdev); if (r) goto err_init_ports; ... err_runtime_get: pm_runtime_disable(&pdev->dev); dss_uninit_ports(pdev); err_init_ports: if (dss.video1_pll) dss_video_pll_uninit(dss.video1_pll); ... dss_uninit_ports() is not called on partially initialized ports (when dss_init_ports() returns an error we go straight into err_init_ports label and skip dss_uninit_ports()) > -Arvind > > > On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote: > > dpi_uninit_port() & sdi_uninit_port() skip not fully > > initialized port Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics