From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbdKMEI5 (ORCPT ); Sun, 12 Nov 2017 23:08:57 -0500 Received: from anchovy1.45ru.net.au ([203.30.46.145]:45158 "EHLO anchovy.45ru.net.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751653AbdKMEIz (ORCPT ); Sun, 12 Nov 2017 23:08:55 -0500 Subject: Re: [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional To: Pan Bian , Andrew Lunn , Vivien Didelot , Florian Fainelli Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <1510501089-9451-1-git-send-email-bianpan2016@163.com> From: Phil Reid Message-ID: <251e5e33-8bbb-d745-63c8-95d7b34d95f0@electromag.com.au> Date: Mon, 13 Nov 2017 12:08:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510501089-9451-1-git-send-email-bianpan2016@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2017 23:38, Pan Bian wrote: > Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its > return value should not be validated by a NULL check. Instead, use IS_ERR. > > Signed-off-by: Pan Bian > --- > drivers/net/dsa/lan9303-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c > index b471413..6d3fc8f 100644 > --- a/drivers/net/dsa/lan9303-core.c > +++ b/drivers/net/dsa/lan9303-core.c > @@ -828,7 +828,7 @@ static void lan9303_probe_reset_gpio(struct lan9303 *chip, > chip->reset_gpio = devm_gpiod_get_optional(chip->dev, "reset", > GPIOD_OUT_LOW); > > - if (!chip->reset_gpio) { > + if (IS_ERR(chip->reset_gpio)) { > dev_dbg(chip->dev, "No reset GPIO defined\n"); > return; > } > Should not an error actually report the error and error out (ie fail probe). But a null is the optional return and ok. (ie when -ENOENT return from sub gpiod_get call). IS_ERR should be a separate condition check I think. related lan9303_handle_reset() always returns 0. lan9303_probe checks lan9303_handle_reset() return value. Probably should be checking lan9303_probe_reset_gpio() instead. -- Regards Phil Reid