From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D8222D7DD7 for ; Tue, 21 Apr 2026 13:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776441; cv=none; b=OIJXK5kR4O8mZo5knrqB+RSy5aIXZkn68eQ+afkvxdHZEpgoOfvwPoL9TJOEDF5ueH/3w9zb07cxxm9GUEA5944y1mZr/UI7c25mp6D0P/7OrZU50JHsa4exazq093yJ7coixof9YVGUUsqx63bn3UTW3zMST02V6OErTd/fHN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776776441; c=relaxed/simple; bh=tiwrcb1ZdzpanGae6iugYwFXzX8mwDGXiuvH1E1kdzs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n4r0F1563OJ887Awghw+kr0HiZjNI1oy2LYfgD0o1l9sDz3eOzVIn5kSsSCZTMCoGtkkKSVM7f6iKmqlou5J9UKXpK+EVenzQJY2994RKE1Fd3o4I6vBJdmnpXjwFoHijQI2mIBk1Qc0czB8InrZcdHRmqPVMWtGSvFg1jzUYSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JMBrDRio; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J3/XmXeU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JMBrDRio"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J3/XmXeU" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63L9f9w94169095 for ; Tue, 21 Apr 2026 13:00:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7lvnln9/rgbiDxukmCo33hD3qG0KmpVWAD0BX5Cqj34=; b=JMBrDRioSUlYbGAO 2TDAZHbW+q46MMawUgYNH7iOkFcfVFT8zequXVB5948kDc2BTxX11Ox9vb7AcAx+ geEeKwVNsHjF4g16csqVKoFy4f8V5MuNXhfnSMbM9h+/quUie7xcjbAfR5N3UuXA tL+KlFApqqimO8MGb6mH/aiDQuuO36rbYJ7woSZNL1/cO7JVgWQF5Ly/hQp6caWZ nGoLKg5nvA0ZBYsSXQUR4TREsOzUa8mOagtOC3hz8Fxl0Cc62G0+v8XhZ8GEnlWO UVQFGXMDtMph/UQTHW4OgtFZvNK8wjGWtroV/5kmkVLxbvZFx53m0fqYxNUGoHTl 8wonhQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dp1au20c7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Apr 2026 13:00:39 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50de6db1eabso10115521cf.0 for ; Tue, 21 Apr 2026 06:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776776438; x=1777381238; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7lvnln9/rgbiDxukmCo33hD3qG0KmpVWAD0BX5Cqj34=; b=J3/XmXeUZZOsvW2Yk9kpvhmvfNI82S5f7WfOdI1UO+dLVAr+pB2Iouade0wWuhLKRX mWXJMfCyqzLZzh/sKraK9Ti5dozeC8gwXHzHcqzwvxCfi/C8pr++YjOKAXJhaZB9+hrR iBB1oncjbzqjZVnc7F4LJzg/j6coaQxrpGVqs2q6CfcvIeGv1BRmEenJvGhZBnhG2YPg Z5DY+6W2gALG5cdRwXt9NDsvWDPgrHGaMlgspIhGnUN2oAKmHo1jDE90qV6J8/Kk7Wkq zGfUhXMS2JE1MKAMt4M7xde5uJIRyA3yA1iSyW9MYcwF01upCxTVO34w/RsnBOlyvEPd efnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776776438; x=1777381238; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7lvnln9/rgbiDxukmCo33hD3qG0KmpVWAD0BX5Cqj34=; b=IIhDOvkOMHyGQfIi3CX5OCPX/I9NoppCGkNCmwDbAFGGKp40nCYNzu3Xd8Qmyzla2Z FsXJX4Iu0P/70V9VeFd7GlMborMExx9edr/0hbDCqh2tyD/J+YehrjZ8ELalZyBGbhkg MSwGlANzo4GIMOH2UDp8BxABDQ0JYGGDUVHPiLKlnWm8kSxII8olPSojbfWYP9LFFe59 50UGROCCYBWg1XGijSmeu53bsh2+XTur0ff5zomqjs41y7zFb7a+GFEVzgth5dQtOUUQ UoVVtQtKSSYqWnV8OGPYHS4qgdIJg9r4wHNwLlfV3oRRY1aqJRFULPnWqnkRBDbFFoBs /j6A== X-Forwarded-Encrypted: i=1; AFNElJ+y/kD2HaVt39W63LVjXaCu4BGVhhjznRhzjc4mKxp9IA+UYJ795pFtV6WRuOh92jaazjd81DqgnxWOU9s=@vger.kernel.org X-Gm-Message-State: AOJu0YzYhTqP1Q9bq5iHjibyKjL7pdwfmh5m8CixX2eKs6ldkpk1ECzE WQE3nPdaISx9B6MF4XHAWoJzGYbU13tOiPm438D4142d2wb4MpwKRc7FjKvb4lguhNZP7UZGbaj 8yy9oAUK1YCaOacpxnkXPW0i2pXUU8hrKlwS+pCZBEI6HwRz/baE2yFm68OvmGGWuaIU= X-Gm-Gg: AeBDiesLczl9XnWOuCg24ldgHF7BNCAqm7YPfJHQFIQPC9yCh0/LIXuK9FtzGJpWv9g WCCRBk+nFQ7FjGi5+DdGy0K4Nwkuj8CNXKNqn18WG83rCSmhBfN3gXu+oMYF1bHr6NWUxH+x2Mi KNz8SC3qSVEEUO70aoyJNryDePy+FttdVdtc0u1PlNFHYMuNieAC2yZiq4ltYSKJQWmLyLDRluT yJAgriwLkeiJmRtpKEXnWbyxKHcAVjxnzXBwvT72r8nBqQgOhIHQGPIng0VH6Oty5og6m2mYnWU rovktpqxVZSswOw//rhM6/54TWgBI9co4pYNbmPPSGwMfGJD/9/TpEFSeF+RhKaXGaE8doXxuPr U89k70+cs6RhClhY9X9UXnWVdufyGXNBHfEA7RF29j0d3iDultkScElBhALn/aOCz1U2ftc6XBD w= X-Received: by 2002:ac8:7d14:0:b0:50e:df3b:80 with SMTP id d75a77b69052e-50edf3b0365mr60846991cf.8.1776776438231; Tue, 21 Apr 2026 06:00:38 -0700 (PDT) X-Received: by 2002:ac8:7d14:0:b0:50e:df3b:80 with SMTP id d75a77b69052e-50edf3b0365mr60845871cf.8.1776776437463; Tue, 21 Apr 2026 06:00:37 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba455046429sm442637266b.50.2026.04.21.06.00.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2026 06:00:36 -0700 (PDT) Message-ID: <25244bbe-0500-4712-8ab6-eca060b942e3@oss.qualcomm.com> Date: Tue, 21 Apr 2026 15:00:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] phy: qcom: edp: Add eDP/DP mode switch support To: Yongxing Mou , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260302-edp_phy-v3-0-ca8888d793b0@oss.qualcomm.com> <20260302-edp_phy-v3-1-ca8888d793b0@oss.qualcomm.com> <245f4589-d7ca-4d6b-8162-a86972752bd8@oss.qualcomm.com> <12e8a8de-49b8-463a-8b88-2cbbf1ab901c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIxMDEyOSBTYWx0ZWRfX/eVmEQWElavi Ru96wx0EXOJJ6woQOhhQUFSaqcb6AE3Pf+GRkiEBYRWl5MozrmwgrWWDBBa3spvA0cX65eGvdVp zOUoytpqWudmQ9gfzEt2nlg7bs7IrF51GW9XVlCaXB4HXMwwM3cqMZpP4Rjr0GNof2MNwwgVcvW dUJ64ssJwhLnyjRUHPI9PVwJcxFbHZcWm2cgrIdHUN4X4QEBF4wt7ERQ2k6+szl8jpHt8ONyHqA wAO89UFc9qLfgpScRaZXqDSP20iyjSg0wfFdO3aG8bt2o0enGumtxq+XR3mhoDO9HsWWKwgT8jR HXWzEdh4R7u+Wb+pZnq7f/ND/7wciJU62yfDIG0f8CVeJOGKOnZj05SneUrLOwzTbEVZ6pq77+t r004iNgap4elcXgoAMo0UGvEgWldFAU3r1chnsJTxvLQjEZA481RrmLNPvRiYHog+dE2xW9/z5K 766SUXxBXMrx/i9DWyQ== X-Authority-Analysis: v=2.4 cv=F9JnsKhN c=1 sm=1 tr=0 ts=69e774f7 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=9dqbPrMe-NXFaFYHzLoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: iVHoZBK7uf0A8Y1K2O5qMTiiBhGvFEPu X-Proofpoint-ORIG-GUID: iVHoZBK7uf0A8Y1K2O5qMTiiBhGvFEPu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_02,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604210129 On 4/21/26 5:54 AM, Yongxing Mou wrote: > > > On 4/20/2026 8:49 PM, Konrad Dybcio wrote: >> On 4/20/26 2:48 PM, Yongxing Mou wrote: >>> >>> >>> On 4/16/2026 5:34 PM, Konrad Dybcio wrote: >>>> On 3/2/26 9:28 AM, Yongxing Mou wrote: >>>>> The eDP PHY supports both eDP&DP modes, each requires a different table. >>>>> The current driver doesn't fully support every combo PHY mode and use >>>>> either the eDP or DP table when enable the platform. In addition, some >>>>> platforms mismatch between the mode and the table where DP mode uses >>>>> the eDP table or eDP mode use the DP table. >>>>> >>>>> Clean up and correct the tables for currently supported platforms based on >>>>> the HPG specification. >>>>> >>>>> Here lists the tables can be reused across current platforms. >>>>> DP mode： >>>>>      -sa8775p/sc7280/sc8280xp/x1e80100 >>>>>      -glymur >>>>> eDP mode(low vdiff): >>>>>      -glymur/sa8775p/sc8280xp/x1e80100 >>>>>      -sc7280 >>>>> >>>>> Cc: stable@vger.kernel.org >>>>> Fixes: f199223cb490 ("phy: qcom: Introduce new eDP PHY driver") >>>>> Signed-off-by: Yongxing Mou >>>>> --- >>>> >>>> I went through everything and all the sequences are OK. >>>> >>>> SC8180X will need changes, but it's already incorrect so this >>>> doesn't necessarily affect it >>>> >>>> Thanks! >>>> >>>> Reviewed-by: Konrad Dybcio >>>> >>>> Konrad >>> Thanks here.. I didn’t notice before that SC8180X is different from SC7280, and will correct it in the next version. >> >> Please make it another patch on top of these two, so that we don't have >> to re-validate the existing diff >> >> Konrad > Thanks very much for the validating this patch. Could you sync with Dmitry how i post next patch?... He suggest me to splite this patch... Eh I guess he's right.. I think the following approach should be fine: - take your current change - split it up into smaller pieces (so that the resulting diff is the same) - add a 8180 fixup on top Konrad