mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Daniel Palmer <daniel@thingy.jp>, linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev/tdfxfb: Make the VGA register initialisation a bit more obvious
Date: Fri, 27 Feb 2026 15:27:22 +0100	[thread overview]
Message-ID: <252a732a-67b8-44ed-a198-08f95c2d3be4@gmx.de> (raw)
In-Reply-To: <20260227122500.3885069-1-daniel@thingy.jp>

On 2/27/26 13:25, Daniel Palmer wrote:
> For a while I was trying to get this working on m68k, for some reason
> the card doesn't display anything if it's own video BIOS didn't run..
> 
> Anyhow, I spent a long time looking up what each of these offsets
> were to work out what the code is configuring and eventually
> replaced them with the human readable defines in video/vga.h.
> 
> Functionally there is no change but maybe it makes it a bit easier to
> look at for the next person that finds themselves in here.
> 
> Tested on a real voodoo 3 on x86_64.
> 
> Signed-off-by: Daniel Palmer <daniel@thingy.jp>
> ---
>   drivers/video/fbdev/tdfxfb.c | 109 ++++++++++++++++++-----------------
>   1 file changed, 55 insertions(+), 54 deletions(-)

applied to fbdev git tree.

Thanks for the cleanup!
Helge

      reply	other threads:[~2026-02-27 14:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 12:25 Daniel Palmer
2026-02-27 14:27 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252a732a-67b8-44ed-a198-08f95c2d3be4@gmx.de \
    --to=deller@gmx.de \
    --cc=daniel@thingy.jp \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®