From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jiri Slaby <jslaby@suse.cz>, tsbogend@alpha.franken.de
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH] mips: traps, add __init to parity_protection_init
Date: Thu, 23 Jul 2020 13:00:14 +0300 [thread overview]
Message-ID: <252bf1ae-6c1d-463e-a035-debb119fa83d@cogentembedded.com> (raw)
In-Reply-To: <20200723094235.12706-1-jslaby@suse.cz>
Hello!
On 23.07.2020 12:42, Jiri Slaby wrote:
> It references __initdata and is called only from an __init function:
> trap_init. This avoids section mismatches (which I am seeing with gcc
> 10).
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> ---
> arch/mips/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index f655af68176c..702143ad7b47 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -1680,7 +1680,7 @@ __setup("nol2par", nol2parity);
> * Some MIPS CPUs can enable/disable for cache parity detection, but do
> * it different ways.
> */
> -static inline void parity_protection_init(void)
> +static inline __init void parity_protection_init(void)
*inline* in a .c file? Perhaps gcc-10 has it out-of-line?
[...]
MBR, Sergei
next prev parent reply other threads:[~2020-07-23 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 9:42 Jiri Slaby
2020-07-23 10:00 ` Sergei Shtylyov [this message]
2020-07-24 11:15 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=252bf1ae-6c1d-463e-a035-debb119fa83d@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome