From: Matthias Brugger <matthias.bgg@gmail.com>
To: Hsin-Te Yuan <yuanhsinte@chromium.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
Ben Ho <Ben.Ho@mediatek.com>, Hsin-Yi Wang <hsinyi@chromium.org>,
Nicolas Boichat <drinkcat@chromium.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: mt8183: kukui: Fix the address of eeprom at i2c4
Date: Mon, 9 Sep 2024 13:09:04 +0200 [thread overview]
Message-ID: <252cba39-b55c-4ea8-9a5e-271b77a6a064@gmail.com> (raw)
In-Reply-To: <20240909-eeprom-v1-2-1ed2bc5064f4@chromium.org>
On 09/09/2024 10:33, Hsin-Te Yuan wrote:
> The address of eeprom should be 50.
>
> Fixes: ff33d889567e ("arm64: dts: mt8183: Add kukui kodama board")
> Fixes: d1eaf77f2c66 ("arm64: dts: mt8183: Add kukui kakadu board")
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++--
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> index bfb9e42c8acaa7c2e5515888a77fe97258a1b78a..ff02f63bac29b2c473bfdd90a15aba09c2915271 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> @@ -92,9 +92,9 @@ &i2c4 {
> clock-frequency = <400000>;
> vbus-supply = <&mt6358_vcn18_reg>;
>
> - eeprom@54 {
> + eeprom@50 {
> compatible = "atmel,24c32";
> - reg = <0x54>;
> + reg = <0x50>;
> pagesize = <32>;
> vcc-supply = <&mt6358_vcn18_reg>;
> };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> index 5c1bf6a1e475865fc0f6187e9733d7d98908797e..da6e767b4ceede9f5258274fbd702c6e6929f515 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> @@ -79,9 +79,9 @@ &i2c4 {
> clock-frequency = <400000>;
> vbus-supply = <&mt6358_vcn18_reg>;
>
> - eeprom@54 {
> + eeprom@50 {
> compatible = "atmel,24c64";
> - reg = <0x54>;
> + reg = <0x50>;
> pagesize = <32>;
> vcc-supply = <&mt6358_vcn18_reg>;
> };
>
next prev parent reply other threads:[~2024-09-09 11:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 8:33 [PATCH 0/2] Fix the address of eeprom of mt8183-kukui Hsin-Te Yuan
2024-09-09 8:33 ` [PATCH 1/2] arm64: dts: mt8183: krane: Fix the address of eeprom at i2c4 Hsin-Te Yuan
2024-09-09 11:08 ` Matthias Brugger
2024-09-09 11:41 ` AngeloGioacchino Del Regno
2024-10-08 8:16 ` Chen-Yu Tsai
2024-09-09 8:33 ` [PATCH 2/2] arm64: dts: mt8183: kukui: " Hsin-Te Yuan
2024-09-09 11:09 ` Matthias Brugger [this message]
2024-09-09 11:41 ` AngeloGioacchino Del Regno
2024-10-08 8:55 ` [PATCH 0/2] Fix the address of eeprom of mt8183-kukui AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=252cba39-b55c-4ea8-9a5e-271b77a6a064@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Ben.Ho@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=eballetbo@kernel.org \
--cc=hsinyi@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh@kernel.org \
--cc=yuanhsinte@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®