Re: [RFC PATCH 0/3] media: rockchip: VEPU510 H.264 encoder for RK3576

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

Hi Paul.

Le jeudi 23 juillet 2026 à 20:41 +0200, Paul Kocialkowski a écrit :
> In my opinion it would be fine to have two drivers, but it's really up
> to you. Since you already have a v4l2 base for it, I would encourage you
> to move it to my proposal, which will probably be finalized in a shorter
> time frame than the other proposal and lets you reuse the code you've
> already written. Then you could also add RK3576 support to the drm-ish
> Vulkan Video proposal without too much work when it is ready, reusing the
> RK3588 work.

My main concern is that once you exposed an API, the transition path is near
impossible unless you accept to support both APIs concurrently. So I may raise a
slight objection on the above proposal. Once we have the code shared (Detlev is
working on it), you'll see that Detlev (and Daniel Almeida) implementation is
just a step ahead, and adding RK3576 to an RK3588 is just a minor update (its
the same chip, different minor version). On top of which, once the kernel driver
will have settled, adding more codecs will mostly (or entirely) happen in
userspace.

With no offense, the RFC here requires significant work before it can be
upstreamed. A lot of the code is hex tables generated from inspecting a running
driver. So there is a lot of work to decipher this into clean code.

On that aspect, if you are missing any reference code or technical
documentation, let us know, though I believe most of this is public information
for this chip.

regards,
Nicolas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]