From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbcBHMVN (ORCPT ); Mon, 8 Feb 2016 07:21:13 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:60592 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbcBHMVL (ORCPT ); Mon, 8 Feb 2016 07:21:11 -0500 From: Arnd Bergmann To: Antoine Tenart Cc: catalin.marinas@arm.com, will.deacon@arm.com, tsahee@annapurnalabs.com, linux-arm-kernel@lists.infradead.org, rshitrit@annapurnalabs.com, thomas.petazzoni@free-electrons.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Barak Wasserstrom Subject: Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP Date: Mon, 08 Feb 2016 13:20:40 +0100 Message-ID: <2530828.WgKqLzsO0l@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1454922699-16785-3-git-send-email-antoine.tenart@free-electrons.com> References: <1454922699-16785-1-git-send-email-antoine.tenart@free-electrons.com> <1454922699-16785-3-git-send-email-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vEdqzdnRJofRuf6X9PAAA+d1U2U63QuK1P8g+h9Ddb6QvZhUs9c cCeDbenNHdQOgchpQPan1/cRDNrAD3fgP/peKnprLIK6qaGky5IRJYTsuhCQ2ZE4P7B18oS X7ncVR4/PE/5mffQOMX7+ugmcYtEv+v1aJr+3tKVPHRihktr5qXFfkz8h3dCFNsGzI3AxkU Fw8sKCFHvYIqbgeYSw9QQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:fgzi+5Oh6aU=:mZ54iuynfVBP1A/UaaD4q+ X6UphvBMc2YmUkkS57LtoEUmN0a8H6c5IoEAwGXcqBu3b3Sm3Hlgr4g7JrEv5KrGCHiuNxcRO lz3BTh59CKOuucSi255bapMJQygRoI+rTlMdFHNjuQrP0rQ6zd+PPjHDxWs1fhqq6yxBCXONW Rr/eM098HACcY4JaYbqQi8fKmHRatkmWhHCF6n+MI5Blm6cO6TmJpDV1hofwdnt0wrOLcZXqL Ev1kJKzOjMNGrKUsdkN/Z3ZeUbGUDSwonFnVV6hdBw7/VqZcvk9nXau7lruf5IFqQZmwRQjLR I53MEYCgkSzCLMUPPRRiN5LvHOt3jWs+1nwXFSkSp4Gz3d0fNyc08QB8gwdKjRwjkPK1XxDNo P838LmXqh+hO6/AyL9/7rITvM5dD/Kh8eF4TntobiHGriEuUihvx679wmLvUQXNqXzD/cPzEA +MXckm1Nfi7wDBcwaeblJpAOGtrWlO8qGbt2P6frQLpqZ+JIBdOkE8hRP6ZI7u2/sqejdnC4D 7Wjbdd/7eGlMDd9xU58bqXn5ohT+qQVexcyjt9hKjSrsEst5ID8lL4w0e0vuTtdU1R5SbnxWa TujW7R1WL7wUd9HKM/Wfe1vx1TX8E5oP7ljWVfljU4e1245igvSL5UG2jlg2SAlzqM6UVqt1J t5BRJzmhP12oVhJWwp7TD4oVXprUWOJ+pEof4Yqe+SMyzaLYHvAn2unEp+YJudZUBcZ7R3Mpq ftFf4vOO39oRBtk1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 February 2016 10:11:38 Antoine Tenart wrote: > index 000000000000..3e3080fa45e4 > --- /dev/null > + > +#include > + > +/ { > + model = "Annapurna Labs Alpine v2"; > + compatible = "al,alpine-v2"; > + #address-cells = <2>; > + #size-cells = <2>; > + > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; > + serial2 = &uart2; > + serial3 = &uart3; > + }; Move the aliases to the .dts files and drop the ones that are disabled. > + > + pcie-internal@0xfbc00000 { make this pci@fbc00000 { > + compatible = "pci-host-ecam-generic"; > + device_type = "pci"; > + #size-cells = <2>; > + #address-cells = <3>; > + #interrupt-cells = <1>; > + reg = <0x0 0xfbc00000 0x0 0x100000>; > + interrupt-map-mask = <0xf800 0 0 7>; > + /* add legacy interrupts for SATA only */ > + interrupt-map = <0x4000 0 0 1 &gic 0 53 4>, > + <0x4800 0 0 1 &gic 0 54 4>; What's wrong with the other IRQs? Not connected? > + > + uart0: uart@fd883000 { serial@fd883000 Almost all devices are in the 0xfd000000 range. Could this be a bus in the SoC that has all the devices attached to it? Maybe use a "ranges" property to reflect that. In doubt, use the register numbers from the data sheet if you have one. Arnd