From: Valdis.Kletnieks@vt.edu
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] printk: Let %pR handle NULL pointers
Date: Sun, 04 Jan 2009 00:14:34 -0500 [thread overview]
Message-ID: <25339.1231046074@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sat, 03 Jan 2009 21:02:15 PST." <Pine.LNX.4.58.0901031827380.25853@shell2.speakeasy.net>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Sat, 03 Jan 2009 21:02:15 PST, Trent Piepho said:
> resource pointer. Maybe "[]" or "[-]" would be better? A null MAC address
> could be ":::::" or "x:x:x:x:x:x". "N.U.L.L" or "x.x.x.x" for a null IP4
> address. And so on. So the printout looks nicer when a NULL pointer isn't
> a bug.
Have to be careful for IPv6 addresses - '::' is a legal representation of
an all-zeros address. Also, N.U.L.L. may give indigestion to logfile parsers
that are expecting a numeric value in the IP address. It's however unclear
whether we should pick something that doesn't have 3 periods in it, so it
can't match, or whether *that* will give regexp-based logfile readers
indigestion when they don't pick up an IP address where they expected...
Do we want the %pI6 format to do the multiple-zeros -> :: compression?
(Adding netdev to cc: list)
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2009-01-04 5:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-03 10:42 Trent Piepho
2009-01-03 17:10 ` Linus Torvalds
2009-01-03 19:33 ` Harvey Harrison
2009-01-03 21:53 ` Benjamin Herrenschmidt
2009-01-04 5:02 ` Trent Piepho
2009-01-04 5:14 ` Valdis.Kletnieks [this message]
2009-01-04 9:31 ` Johannes Berg
2009-01-04 9:48 ` Benjamin Herrenschmidt
2009-01-04 20:41 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25339.1231046074@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®