From: Shuah Khan <skhan@linuxfoundation.org>
To: Justin Stitt <justinstitt@google.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Shuah Khan <shuah@kernel.org>
Cc: Eduard Zingerman <eddyz87@gmail.com>,
linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
Benjamin Tissoires <bentiss@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 2/3] selftests/hid: do not manually call headers_install
Date: Mon, 18 Sep 2023 11:24:57 -0600 [thread overview]
Message-ID: <2535d4a7-62fe-c9b2-3b86-cf418760087e@linuxfoundation.org> (raw)
In-Reply-To: <20230908-kselftest-09-08-v2-2-0def978a4c1b@google.com>
On 9/8/23 16:22, Justin Stitt wrote:
> From: Benjamin Tissoires <bentiss@kernel.org>
>
> "make headers" is a requirement before calling make on the selftests
> dir, so we should not have to manually install those headers
>
> Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Thank for making this change. Just check bpf continues to
compile and run though.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2023-09-18 17:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 22:22 [PATCH v2 0/3] selftests/hid: fix building for older kernels Justin Stitt
2023-09-08 22:22 ` [PATCH v2 1/3] selftests/hid: ensure we can compile the tests on kernels pre-6.3 Justin Stitt
2023-09-11 13:19 ` Eduard Zingerman
2023-09-11 13:39 ` Benjamin Tissoires
2023-09-11 13:43 ` Eduard Zingerman
2023-09-08 22:22 ` [PATCH v2 2/3] selftests/hid: do not manually call headers_install Justin Stitt
2023-09-18 17:24 ` Shuah Khan [this message]
2023-09-08 22:22 ` [PATCH v2 3/3] selftests/hid: force using our compiled libbpf headers Justin Stitt
2023-09-08 23:02 ` [PATCH v2 0/3] selftests/hid: fix building for older kernels Nick Desaulniers
2023-09-26 7:26 ` Justin Stitt
2023-10-02 14:48 ` Benjamin Tissoires
2023-10-03 22:34 ` Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2535d4a7-62fe-c9b2-3b86-cf418760087e@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bentiss@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=jikos@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®