mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org,
	Prathosh Satish <Prathosh.Satish@microchip.com>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Shannon Nelson <shannon.nelson@amd.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, Michal Schmidt <mschmidt@redhat.com>,
	Petr Oros <poros@redhat.com>
Subject: Re: [PATCH net-next v13 12/12] dpll: zl3073x: Add support to get/set frequency on pins
Date: Mon, 7 Jul 2025 14:02:51 +0100	[thread overview]
Message-ID: <25360415-bd91-4523-b0a6-664d22ba9f37@linux.dev> (raw)
In-Reply-To: <idzmiaubwlnkzds2jbminyr46vuqo37nz5twj7f2yytn4aqoff@r34cm3qpd5mj>

On 07/07/2025 09:32, Jiri Pirko wrote:
> Fri, Jul 04, 2025 at 08:22:02PM +0200, ivecera@redhat.com wrote:
> 
> [...]
> 
>> +static int
>> +zl3073x_dpll_input_pin_frequency_set(const struct dpll_pin *dpll_pin,
>> +				     void *pin_priv,
>> +				     const struct dpll_device *dpll,
>> +				     void *dpll_priv, u64 frequency,
>> +				     struct netlink_ext_ack *extack)
> 
> Unrelated to this patch, but ny idea why we don't implement
> "FREQUENCY_CAN_CHANGE" capability. I think we are missing it.
> 
Do you mean that some DPLLs may implement fixed frequency pins and
we have to signal it back to user-space?

  parent reply	other threads:[~2025-07-07 13:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04 18:21 [PATCH net-next v13 00/12] Add Microchip ZL3073x support (part 1) Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 01/12] dt-bindings: dpll: Add DPLL device and pin Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 02/12] dt-bindings: dpll: Add support for Microchip Azurite chip family Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 03/12] devlink: Add support for u64 parameters Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 04/12] devlink: Add new "clock_id" generic device param Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 05/12] dpll: Add basic Microchip ZL3073x support Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 06/12] dpll: zl3073x: Fetch invariants during probe Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 07/12] dpll: zl3073x: Read DPLL types and pin properties from system firmware Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 08/12] dpll: zl3073x: Register DPLL devices and pins Ivan Vecera
2025-07-04 18:21 ` [PATCH net-next v13 09/12] dpll: zl3073x: Implement input pin selection in manual mode Ivan Vecera
2025-07-04 18:22 ` [PATCH net-next v13 10/12] dpll: zl3073x: Add support to get/set priority on input pins Ivan Vecera
2025-07-04 18:22 ` [PATCH net-next v13 11/12] dpll: zl3073x: Implement input pin state setting in automatic mode Ivan Vecera
2025-07-04 18:22 ` [PATCH net-next v13 12/12] dpll: zl3073x: Add support to get/set frequency on pins Ivan Vecera
2025-07-07  8:32   ` Jiri Pirko
2025-07-07  9:46     ` Ivan Vecera
2025-07-07 10:45       ` Jiri Pirko
2025-07-07 13:02     ` Vadim Fedorenko [this message]
2025-07-07 13:10       ` Ivan Vecera
2025-07-07  8:28 ` [PATCH net-next v13 00/12] Add Microchip ZL3073x support (part 1) Jiri Pirko
2025-07-07  9:51   ` Ivan Vecera
2025-07-07  8:38 ` Jiri Pirko
2025-07-10  2:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25360415-bd91-4523-b0a6-664d22ba9f37@linux.dev \
    --to=vadim.fedorenko@linux.dev \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Prathosh.Satish@microchip.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=ivecera@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=jiri@resnulli.us \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=poros@redhat.com \
    --cc=robh@kernel.org \
    --cc=shannon.nelson@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®