From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752707AbdGYQS5 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Jul 2017 12:18:57 -0400
Received: from cloudserver094114.home.net.pl ([79.96.170.134]:59418 "EHLO
        cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752243AbdGYQS4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Jul 2017 12:18:56 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend()
Date: Tue, 25 Jul 2017 18:10:57 +0200
Message-ID: <2537138.AhdhMFtmoG@aspire.rjw.lan>
User-Agent: KMail/4.14.10 (Linux/4.12.0-rc1+; KDE/4.14.9; x86_64; ; )
In-Reply-To: <20170725100012.GH2369@lahna.fi.intel.com>
References: <4063610.TqANq0McE8@aspire.rjw.lan> <20170725100012.GH2369@lahna.fi.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, July 25, 2017 01:00:12 PM Mika Westerberg wrote:
> On Tue, Jul 25, 2017 at 01:31:00AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > 
> > On one of my test machines nhi_mailbox_cmd() called from icm_suspend()
> > times out and returnes an error which then is propagated to the
> > caller and causes the entire system suspend to be aborted which isn't
> > very useful.
> > 
> > Instead of aborting system suspend, print the error into the log
> > and continue.
> 
> I agree, it should not prevent suspend but I wonder why it fails in the
> first place? Can you check what is the return value?

As per the above, the error is a timeout, ie. -ETIMEDOUT.