mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thiago Macieira <thiago.macieira@intel.com>
To: Michal Marek <mmarek@suse.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: make xconfig no longer works in Fedora
Date: Mon, 02 Nov 2015 11:01:44 -0500	[thread overview]
Message-ID: <25378935.a1olKg0W2g@tjmaciei-mobl4> (raw)
In-Reply-To: <20151102155033.GA15852@sepie.suse.cz>

On Monday 02 November 2015 16:50:33 Michal Marek wrote:
> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
> > On Monday 02 November 2015 11:36:43 Michal Marek wrote:
> > > On 2015-11-02 04:20, Thiago Macieira wrote:
> > > > -	qtver=`qmake -query QT_VERSION` || { \
> > > > +	qtver=`qmake -query QT_VERSION` || \
> > > > +	qtver=`qmake-qt5 -query QT_VERSION` || \
> > > > +	qtver=`qmake-qt4 -query QT_VERSION` || { \
> > > 
> > > The qtlibdir= etc assignments below still use qmake directly, plus this
> > > will print an error if the command is not called "qmake." As Alexey
> > > says, we do not need qmake, we need moc and the cflags / ldflags. Since
> > > pkg-config worked for us previously, I suggest to use pkg-config again
> > > and just check which of QtGui or Qt5Widgets is available.
> > 
> > Here's an attempt using pkg-config.
> 
> Works for me on openSUSE, it just started to prefer Qt5 now. But it
> correctly builds against Qt4 if Qt5 is not available.

That's a consequence of using pkg-config. Now you can no longer choose your 
preferred Qt version by setting QT_SELECT, like the qmake solution would have 
allowed, as recommended by the Qt Project. At least, the qtchooser shell 
function extension does set PKG_CONFIG_PATH, so if you  install a different 
version elsewhere, that version should be picked up.

It would have been the same with CMake too, btw.

Alexey, did this solve the problem for you?
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


  reply	other threads:[~2015-11-02 16:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-31 12:39 Alexey Brodkin
2015-11-02  3:20 ` Thiago Macieira
2015-11-02 10:36   ` Michal Marek
2015-11-02 13:46     ` Thiago Macieira
2015-11-02 15:50       ` Michal Marek
2015-11-02 16:01         ` Thiago Macieira [this message]
2015-11-02 16:07           ` Michal Marek
2015-11-02 16:28           ` Alexey Brodkin
2015-11-02 20:38             ` Michal Marek
2015-11-02 20:43               ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25378935.a1olKg0W2g@tjmaciei-mobl4 \
    --to=thiago.macieira@intel.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®