Hi Andrew, This patch updates all the device attribute callbacks that weren't updated with the new parameter, I guess because they weren't in Greg's tree (including drivers/pcmcia/ds.c). Without the patch these callbacks are probably broken (and generate a warning along the lines of "assignment from incompatible pointer type"). Please see http://lkml.org/lkml/2005/5/19/40 for the scripts I used to update the attributes automatically. Signed-off-by: Yani Ioannou Thanks, Yani char/tpm/tpm.c | 2 +- char/tpm/tpm.h | 8 ++++---- message/i2o/bus-osm.c | 2 +- message/i2o/exec-osm.c | 4 ++-- pcmcia/ds.c | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-)