RE: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller

["Bi, Chao" <chao.bi@intel.com>]

Sorry for that, please check my resubmitted patch right now.

Thanks,
Chao

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org] 
Sent: Wednesday, January 16, 2013 10:50 AM
To: Bi, Chao
Cc: Alan Cox; Gorby, Russ; Chen, Jun D; linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller

On Wed, Dec 12, 2012 at 01:07:06PM +0800, chao bi wrote:
> 
> As protocol driver, IFX SPI driver initiate to setup SPI master with 
> default SPI word size as 16 bit/word, however, SPI master may not 
> adopt this default value due to SPI controller's capability, it might 
> choose an available value by itself and set it to 
> spi_device.bits_per_word. In order to keep align with Controller, IFX 
> driver should make use of this value during SPI transfer, but the default one.
> 
> Signed-off-by: Chen Jun <jun.d.chen@intel.com>
> Signed-off-by: channing <chao.bi@intel.com>
> ---
>  drivers/tty/serial/ifx6x60.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/tty/serial/ifx6x60.c 
> b/drivers/tty/serial/ifx6x60.c index 675d94a..5919992 100644
> --- a/drivers/tty/serial/ifx6x60.c
> +++ b/drivers/tty/serial/ifx6x60.c
> @@ -810,7 +810,8 @@ static void ifx_spi_io(unsigned long data)
>  		ifx_dev->spi_xfer.cs_change = 0;
>  		ifx_dev->spi_xfer.speed_hz = ifx_dev->spi_dev->max_speed_hz;
>  		/* ifx_dev->spi_xfer.speed_hz = 390625; */
> -		ifx_dev->spi_xfer.bits_per_word = spi_bpw;
> +		ifx_dev->spi_xfer.bits_per_word =
> +		ifx_dev->spi_dev->bits_per_word;

Please follow the proper coding style (hint, this isn't it.)

thanks,

greg k-h