From: Dev Jain <dev.jain@arm.com>
To: Hao Ge <hao.ge@linux.dev>, Uladzislau Rezki <urezki@gmail.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@gentwo.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [PATCH v4 5/9] mm/vmalloc: BUG_ON() on an unaligned range in __vunmap_range_noflush()
Date: Mon, 16 Nov 2026 09:45:58 +0530 [thread overview]
Message-ID: <253a1587-0f76-4013-babc-f7c9c0295eee@arm.com> (raw)
In-Reply-To: <cea5d9af-435a-4708-a937-59c7cbcb169e@linux.dev>
On 16/11/26 8:51 am, Hao Ge wrote:
>
>
> On 2026/11/12 20:15, Uladzislau Rezki wrote:
>> On Tue, Nov 10, 2026 at 07:25:42PM +0800, Hao Ge wrote:
>>> The PTE loop of the unmap path stops only at addr == end. With an
>>> unaligned end addr never lands on end, so the loop walks past the
>>> range and keeps clearing. With an unaligned start the loop begins
>>> in the page containing start, which extends below the range. Either
>>> way the unmap clears the mappings adjacent to the range, and that is
>>> nearly impossible to debug afterwards.
>>>
>>> vmap only installs page-aligned, page-granular mappings, so an
>>> unaligned unmap request is never a legitimate teardown, and there is
>>> no way to tell which pages the caller meant. Check addr and end at
>>> the entry of __vunmap_range_noflush() and bug out before any PTE is
>>> cleared.
>>>
>>> Signed-off-by: Hao Ge <hao.ge@linux.dev>
>>> ---
>>> mm/vmalloc.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>>> index 86fbb1d2b27a..0565cbfe325c 100644
>>> --- a/mm/vmalloc.c
>>> +++ b/mm/vmalloc.c
>>> @@ -518,6 +518,8 @@ void __vunmap_range_noflush(unsigned long start, unsigned long end)
>>> pgtbl_mod_mask mask = 0;
>>>
>>> BUG_ON(addr >= end);
>>> + BUG_ON(!PAGE_ALIGNED(addr) || !PAGE_ALIGNED(end));
>>> +
>>> pgd = pgd_offset_k(addr);
>>> do {
>>> next = pgd_addr_end(addr, end);
>>> --
>>> 2.25.1
>>>
>> I am not sure this is good to stop machine at all. WARN_ON_ONCE()
>> and return?
>
> Folks tend to dislike BUG_ON. Dev suggested switching to this when I sent out v3.
> That's fine. After all, nobody has hit this so far. I'll switch it to WARN_ON_ONCE
> for the next version.
To clarify I had suggested the actual check, not the BUG_ON, I thought it is a
well-known fact in mm now that BUG_ON is not to be used : )
>
>>
>> --
>> Uladzislau Rezki
next prev parent reply other threads:[~2026-11-16 4:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:25 [PATCH v4 0/9] mm/vmalloc: fix up vmap error handling Hao Ge
2026-11-10 11:25 ` [PATCH v4 1/9] mm/kmsan: undo the shadow mapping when the origin mapping fails Hao Ge
2026-11-11 21:03 ` Suren Baghdasaryan
2026-11-12 7:50 ` Hao Ge
2026-11-12 15:50 ` Suren Baghdasaryan
2026-11-10 11:25 ` [PATCH v4 2/9] mm/kmsan: skip vunmap_range_noflush when KMSAN is disabled Hao Ge
2026-11-11 22:10 ` Suren Baghdasaryan
2026-11-12 7:32 ` Hao Ge
2026-11-10 11:25 ` [PATCH v4 3/9] mm/vmalloc: BUG_ON() on an unaligned range in vmap_range_noflush() Hao Ge
2026-11-10 12:28 ` Hao Ge
2026-11-12 0:00 ` Suren Baghdasaryan
2026-11-12 12:23 ` Uladzislau Rezki
2026-11-10 11:25 ` [PATCH v4 4/9] mm/vmalloc: BUG_ON() on an unaligned range in vmap_pages_range_noflush_walk() Hao Ge
2026-11-12 0:16 ` Suren Baghdasaryan
2026-11-12 7:22 ` Hao Ge
2026-11-12 12:11 ` Uladzislau Rezki
2026-11-16 3:15 ` Hao Ge
2026-11-10 11:25 ` [PATCH v4 5/9] mm/vmalloc: BUG_ON() on an unaligned range in __vunmap_range_noflush() Hao Ge
2026-11-12 0:22 ` Suren Baghdasaryan
2026-11-12 12:15 ` Uladzislau Rezki
2026-11-16 3:21 ` Hao Ge
2026-11-16 4:15 ` Dev Jain [this message]
2026-11-10 11:25 ` [PATCH v4 6/9] mm/vmalloc: only flush the cache after the vmap succeeded Hao Ge
2026-11-12 0:30 ` Suren Baghdasaryan
2026-11-12 7:01 ` Hao Ge
2026-11-12 12:16 ` Uladzislau Rezki
2026-11-10 11:25 ` [PATCH v4 7/9] mm/vmalloc: undo partial mappings inside the mapping functions Hao Ge
2026-11-12 1:15 ` Suren Baghdasaryan
2026-11-12 6:27 ` Hao Ge
2026-11-12 12:19 ` Uladzislau Rezki
2026-11-10 11:25 ` [PATCH v4 8/9] powerpc: drop redundant unmaps of failed vmap mappings Hao Ge
2026-11-10 11:25 ` [PATCH v4 9/9] mm/percpu: stop unmapping the CPU that failed to map Hao Ge
2026-11-11 20:45 ` [PATCH v4 0/9] mm/vmalloc: fix up vmap error handling Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=253a1587-0f76-4013-babc-f7c9c0295eee@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=chleroy@kernel.org \
--cc=cl@gentwo.org \
--cc=dennis@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hao.ge@linux.dev \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®