From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DACBC43334 for ; Thu, 7 Jul 2022 03:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235043AbiGGDCj (ORCPT ); Wed, 6 Jul 2022 23:02:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235088AbiGGDC0 (ORCPT ); Wed, 6 Jul 2022 23:02:26 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADFD430F4B for ; Wed, 6 Jul 2022 20:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657162939; x=1688698939; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=zDHr4dBa22BsNwtUtrCF8oK8mc/E+IT+JoPdjpDGUbs=; b=fKS5lJWSo2/Bq9v/t+rIKiMkB8FtX0+P6178EBiqa6f4910/OmAiBtc1 n4a7U9IaVAEg928N2U6kZQLJbLgzpgsnbdSOExViRTFgVZYBTo5FlCukX OVfZyVOO3UzU63I0wY+03mmJqRNeewJ3SLKoPiyCK0HlniMEwjKt8hV0g zcz8HUH0DrsMTtRLDy4pXQaAgCFeU9bYWmA0hMdu2GVSIDSCxRJ3CsqtV kJUWhsRFbOulM3dT9FKy2JNsKjZp7JHk8A4dVWzLnyWwWqnbYc84hIo3C jUM89My4Fh6BZ9Huwh2YQ0Cxe5eMoceW76tBOtJb3vXF9MhJRWzY7Shl1 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="272709111" X-IronPort-AV: E=Sophos;i="5.92,251,1650956400"; d="scan'208";a="272709111" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 20:02:17 -0700 X-IronPort-AV: E=Sophos;i="5.92,251,1650956400"; d="scan'208";a="650936330" Received: from hualiu-mobl1.ccr.corp.intel.com (HELO [10.249.171.209]) ([10.249.171.209]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 20:02:12 -0700 Message-ID: <2547ae6f-9567-fd76-3a51-31ae769d8599@linux.intel.com> Date: Thu, 7 Jul 2022 11:02:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: baolu.lu@linux.intel.com, Eric Auger , "Liu, Yi L" , "Pan, Jacob jun" , Zhangfei Gao , "Zhu, Tony" , "iommu@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v10 08/12] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , "Raj, Ashok" , Will Deacon , Robin Murphy , Jean-Philippe Brucker , "Jiang, Dave" , Vinod Koul References: <20220705050710.2887204-1-baolu.lu@linux.intel.com> <20220705050710.2887204-9-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/7 09:56, Tian, Kevin wrote: >> From: Lu Baolu >> Sent: Tuesday, July 5, 2022 1:07 PM >> >> +struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct >> mm_struct *mm) >> +{ >> + struct iommu_domain *domain; >> + ioasid_t max_pasids; >> + int ret = -EINVAL; > > -EINVAL is not used. Updated. > > Reviewed-by: Kevin Tian > Best regards, baolu