From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Mark Hasemeyer <markhas@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Rob Herring <robh@kernel.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Raul Rangel <rrangel@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 11/24] arm64: dts: mediatek: mt8192: Enable cros-ec-spi as wake source
Date: Wed, 3 Jan 2024 13:22:23 +0100 [thread overview]
Message-ID: <2547e8ce-cc82-4f46-b42e-5c5aa14046bd@collabora.com> (raw)
In-Reply-To: <20240102140734.v4.11.Ibd330d26a00f5e219a7e448452769124833a9762@changeid>
Il 02/01/24 22:07, Mark Hasemeyer ha scritto:
> The cros_ec driver currently assumes that cros-ec-spi compatible device
> nodes are a wakeup-source even though the wakeup-source property is not
> defined.
>
> Some Chromebooks use a separate wake pin, while others overload the
> interrupt for wake and IO. With the current assumption, spurious wakes
> can occur on systems that use a separate wake pin. It is planned to
> update the driver to no longer assume that the EC interrupt pin should
> be enabled for wake.
>
> Add the wakeup-source property to all cros-ec-spi compatible device
> nodes to signify to the driver that they should still be a valid wakeup
> source.
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2024-01-03 12:22 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 21:07 [PATCH v4 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 01/24] resource: Add DEFINE_RES_*_NAMED_FLAGS macro Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 02/24] gpiolib: acpi: Modify acpi_dev_irq_wake_get_by() to use resource Mark Hasemeyer
2024-01-06 14:44 ` Andy Shevchenko
2024-01-08 19:08 ` Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 03/24] i2c: acpi: Modify i2c_acpi_get_irq() " Mark Hasemeyer
2024-01-06 14:48 ` Andy Shevchenko
2024-01-02 21:07 ` [PATCH v4 04/24] dt-bindings: power: Clarify wording for wakeup-source property Mark Hasemeyer
2024-01-09 20:45 ` Rob Herring
2024-01-02 21:07 ` [PATCH v4 05/24] ARM: dts: tegra: Enable cros-ec-spi as wake source Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 06/24] ARM: dts: rockchip: rk3288: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 07/24] ARM: dts: samsung: exynos5420: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 08/24] ARM: dts: samsung: exynos5800: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 09/24] arm64: dts: mediatek: mt8173: " Mark Hasemeyer
2024-01-03 12:22 ` AngeloGioacchino Del Regno
2024-01-02 21:07 ` [PATCH v4 10/24] arm64: dts: mediatek: mt8183: " Mark Hasemeyer
2024-01-03 12:22 ` AngeloGioacchino Del Regno
2024-01-02 21:07 ` [PATCH v4 11/24] arm64: dts: mediatek: mt8192: " Mark Hasemeyer
2024-01-03 12:22 ` AngeloGioacchino Del Regno [this message]
2024-01-02 21:07 ` [PATCH v4 12/24] arm64: dts: mediatek: mt8195: " Mark Hasemeyer
2024-01-03 12:22 ` AngeloGioacchino Del Regno
2024-01-02 21:07 ` [PATCH v4 13/24] arm64: dts: tegra: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 14/24] arm64: dts: qcom: sc7180: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 15/24] arm64: dts: qcom: sc7280: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 16/24] arm64: dts: qcom: sdm845: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 17/24] arm64: dts: rockchip: rk3399: " Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 18/24] of: irq: add wake capable bit to of_irq_resource() Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 19/24] of: irq: Add default implementation for of_irq_to_resource() Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 20/24] of: irq: Remove extern from function declarations Mark Hasemeyer
2024-01-02 21:07 ` [PATCH v4 21/24] device property: Modify fwnode irq_get() to use resource Mark Hasemeyer
2024-01-06 14:52 ` Andy Shevchenko
2024-01-09 20:47 ` Rob Herring
2024-01-02 21:07 ` [PATCH v4 22/24] device property: Update functions to use EXPORT_SYMBOL_GPL() Mark Hasemeyer
2024-01-08 18:32 ` Sakari Ailus
2024-01-02 21:07 ` [PATCH v4 23/24] platform: Modify platform_get_irq_optional() to use resource Mark Hasemeyer
2024-01-06 14:55 ` Andy Shevchenko
2024-01-08 19:09 ` Mark Hasemeyer
2024-01-14 14:04 ` Andy Shevchenko
2024-01-02 21:07 ` [PATCH v4 24/24] platform/chrome: cros_ec: Use PM subsystem to manage wakeirq Mark Hasemeyer
2024-01-03 0:46 ` Stephen Boyd
2024-01-03 17:47 ` Mark Hasemeyer
2024-01-03 20:46 ` Stephen Boyd
2024-01-03 22:25 ` Mark Hasemeyer
2024-01-03 22:45 ` Mark Hasemeyer
2024-01-04 0:38 ` Stephen Boyd
2024-01-04 0:29 ` Stephen Boyd
2024-01-04 4:55 ` Mark Hasemeyer
2024-01-08 19:07 ` Stephen Boyd
2024-01-08 19:56 ` Mark Hasemeyer
2024-01-08 20:47 ` Stephen Boyd
2024-01-22 9:14 ` [PATCH v4 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Matthias Brugger
2024-02-14 17:57 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2547e8ce-cc82-4f46-b42e-5c5aa14046bd@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andriy.shevchenko@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=markhas@chromium.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rrangel@chromium.org \
--cc=sudeep.holla@arm.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®