mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: "Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Daniel Stone" <daniels@collabora.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, kernel@collabora.com,
	Derek Foreman <derek.foreman@collabora.com>,
	Marius Vlad <marius.vlad@collabora.com>
Subject: Re: [PATCH v5 0/3] Add "link bpc" DRM property
Date: Tue, 24 Mar 2026 17:44:21 +0100	[thread overview]
Message-ID: <254c20a4-cce3-4c8e-9902-514586f3e694@mailbox.org> (raw)
In-Reply-To: <4265353.aeNJFYEL58@workhorse>

On 3/24/26 16:25, Nicolas Frattaroli wrote:
> On Monday, 23 March 2026 18:27:41 Central European Standard Time Michel Dänzer wrote:
>> On 3/23/26 17:55, Nicolas Frattaroli wrote:
>>>
>>> "Someone might not understand its purpose" is, in my eyes, not a valid reason to
>>> not have this property, [...]
>> Per my previous posts, that's not my concern.
> 
> Then what is your concern?

Per my previous posts, my concerns are:

* The meaning of the "link bpc" property value isn't defined well enough vs things like dithering or DSC, which will likely result in compositors / users overestimating what value they need / want, resulting in compositors spuriously rejecting configurations which would work perfectly fine, and/or spurious issue reports.

With my compositor developer hat on, what I'd want to know is something like: "How many bits of information can be passed over the link, allowing the display to present it in a way which can be perceived by the user?" With dithering or DSC, that would be a higher value than the physical link bpc.


* There's no clear use case.

This is generally a requirement for new KMS UAPI.

The practical usefulness of the corresponding weston MR is dubious per the concern above.


> That the link-bpc property does not consider DSC and dithering?
> Two things which the max-bpc property also does not consider?

It's not (as much of) an issue with the "max bpc" property because it's just an upper limit, the driver is free to use a lower effective bpc.


> If all you want is a clearer description of the property in the comment that
> accompanies it, then I can do that, and I said I agree with this point.

Patch 3 would need to take dithering & DSC into account as well.


> But you seem to be arguing from a position of not wanting the property to
> exist at all, [...]

I'm not. However, per the first concern above, a not-well-defined property could be worse than none.


-- 
Earthling Michel Dänzer       \        GNOME / Xwayland / Mesa developer
https://redhat.com             \               Libre software enthusiast

  reply	other threads:[~2026-03-24 16:44 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 12:28 Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 1/3] drm/connector: Add a 'link bpc' property Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 2/3] drm/connector: hdmi: Add support for " Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 3/3] drm/amd/display: " Nicolas Frattaroli
2026-03-20 14:32 ` [PATCH v5 0/3] Add "link bpc" DRM property Michel Dänzer
2026-03-20 18:02   ` Nicolas Frattaroli
2026-03-23 10:55     ` Michel Dänzer
2026-03-23 12:05       ` Nicolas Frattaroli
2026-03-23 14:38         ` Michel Dänzer
2026-03-23 16:55           ` Nicolas Frattaroli
2026-03-23 17:27             ` Michel Dänzer
2026-03-24 15:25               ` Nicolas Frattaroli
2026-03-24 16:44                 ` Michel Dänzer [this message]
2026-03-26 12:17                   ` Nicolas Frattaroli
2026-03-30 16:57                     ` Michel Dänzer
2026-03-30 18:52                       ` Harry Wentland
2026-03-31 12:50                         ` Pekka Paalanen
2026-03-31 17:47                           ` Harry Wentland
2026-04-01  8:40                             ` Daniel Stone
2026-04-01 11:10                               ` Ville Syrjälä
2026-04-01 11:43                                 ` Daniel Stone
2026-04-01 12:46                               ` Nicolas Frattaroli
2026-04-02 17:06                                 ` Harry Wentland
2026-04-01 13:57                               ` Ville Syrjälä
2026-04-01 14:17                                 ` Daniel Stone
2026-04-02 17:01                               ` Harry Wentland
2026-03-26 13:53                   ` Pekka Paalanen
2026-03-30 19:01                     ` Harry Wentland
2026-03-31 10:28                       ` Pekka Paalanen
2026-03-31 17:37                         ` Harry Wentland
2026-04-09 15:05                       ` Nicolas Dufresne
2026-03-31  8:01                     ` Michel Dänzer
2026-03-31 12:38                       ` Pekka Paalanen
2026-03-31 12:56                         ` Michel Dänzer
2026-03-31 14:21                           ` Pekka Paalanen
2026-04-01  7:46                             ` Michel Dänzer
2026-06-09 13:53                               ` Pekka Paalanen
     [not found]     ` <CAEsyxyhnALbkaF+9nav8FkW5gcJdtTw5CHhK3Hf8f=fymFiOKw@mail.gmail.com>
2026-03-23 11:44       ` Michel Dänzer
2026-04-09 22:20     ` Dmitry Baryshkov
2026-04-01 11:57 ` Xaver Hugl
2026-04-01 12:11   ` Ville Syrjälä
2026-04-01 12:25     ` Daniel Stone
2026-04-01 12:56       ` Ville Syrjälä
2026-04-01 12:14   ` Nicolas Frattaroli
2026-04-03 10:23     ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=254c20a4-cce3-4c8e-9902-514586f3e694@mailbox.org \
    --to=michel.daenzer@mailbox.org \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniels@collabora.com \
    --cc=derek.foreman@collabora.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marius.vlad@collabora.com \
    --cc=mripard@kernel.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®