From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbdB0KhI (ORCPT ); Mon, 27 Feb 2017 05:37:08 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33150 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdB0Kg7 (ORCPT ); Mon, 27 Feb 2017 05:36:59 -0500 Subject: Re: [PATCH v2] mtd: Fix mtdblock for >4GB MTD devices To: Lepton Wu , dwmw2@infradead.org References: <20170222021558.710-1-ytht.net@gmail.com> Cc: computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, cyrille.pitchen@atmel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <254c5202-64cd-ddae-2e76-8db6a4486b80@gmail.com> Date: Mon, 27 Feb 2017 10:31:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170222021558.710-1-ytht.net@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2017 03:15 AM, Lepton Wu wrote: > Change to use loff_t instead of unsigned long in some functions > to make sure mtdblock can handle offset bigger than 4G in 32 bits mode. > > Signed-off-by: Lepton Wu > --- > Changes in v2: > - Make the commit message more clearer and fix some format issues. > > drivers/mtd/mtdblock.c | 35 ++++++++++++++++++----------------- > drivers/mtd/mtdblock_ro.c | 4 ++-- > 2 files changed, 20 insertions(+), 19 deletions(-) > > diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c > index bb4c14f83c75..373c0edca803 100644 > --- a/drivers/mtd/mtdblock.c > +++ b/drivers/mtd/mtdblock.c > @@ -61,8 +61,8 @@ static void erase_callback(struct erase_info *done) > wake_up(wait_q); > } > > -static int erase_write (struct mtd_info *mtd, unsigned long pos, > - int len, const char *buf) > +static int erase_write(struct mtd_info *mtd, loff_t pos, int len, > + const char *buf) Can the length be 64bit too now ? [...] -- Best regards, Marek Vasut