From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750852AbdCNKxw (ORCPT ); Tue, 14 Mar 2017 06:53:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44078 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbdCNKxv (ORCPT ); Tue, 14 Mar 2017 06:53:51 -0400 Subject: Re: kvm-kmod (Re: [PATCH v2] kvm: better MWAIT emulation for guests) To: "Gabriel L. Somlo" References: <1489421699-20374-1-git-send-email-mst@redhat.com> <20170313201831.GR2365@HEDWIG.INI.CMU.EDU> Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <254df987-e8f6-45b7-e045-86ece8c5854b@redhat.com> Date: Tue, 14 Mar 2017 11:53:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170313201831.GR2365@HEDWIG.INI.CMU.EDU> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 14 Mar 2017 10:53:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/2017 21:18, Gabriel L. Somlo wrote: > I'd like to test Michael's MWAIT patch on my copies of the affected > OS X versions, and wanted to use kvm-kmod to build the latest KVM on > my F24 box. I did: > > git clone git://git.kernel.org/pub/scm/virt/kvm/kvm.git > git clone https://github.com/bonzini/kvm-kmod.git > cd kvm-kmod > ./configure > make LINUX=../kvm clean sync all > > Then, I get a bunch of errors: > > make -C /lib/modules/4.9.10-100.fc24.x86_64/build M=`pwd` clean > make[1]: Entering directory '/usr/src/kernels/4.9.10-100.fc24.x86_64' > make[1]: Leaving directory '/usr/src/kernels/4.9.10-100.fc24.x86_64' > ./sync -v for-linus -l ../kvm > make -C /lib/modules/4.9.10-100.fc24.x86_64/build M=`pwd` \ > LINUXINCLUDE="-I`pwd`/include -I`pwd`/include/uapi -Iinclude \ > -Iinclude2 -I/lib/modules/4.9.10-100.fc24.x86_64/source/include -I/lib/modules/4.9.10-100.fc24.x86_64/source/include/uapi -I/lib/modules/4.9.10-100.fc24.x86_64/source/arch/x86/include -I/lib/modules/4.9.10-100.fc24.x86_64/source/arch/x86/include/uapi \ > -Iinclude/generated/uapi -Iarch/x86/include/generated \ > -Iarch/x86/include/generated/uapi \ > -I`pwd`/include-compat -I`pwd`/x86 \ > -include include/generated/autoconf.h \ > -include `pwd`/x86/external-module-compat.h" \ > "$@" > make[1]: Entering directory '/usr/src/kernels/4.9.10-100.fc24.x86_64' > LD /home/somlo/FOO/kvm-kmod/x86/built-in.o > CC [M] /home/somlo/FOO/kvm-kmod/x86/kvm_main.o > In file included from /home/somlo/FOO/kvm-kmod/x86/external-module-compat.h:46:, > from :0: > /home/somlo/FOO/kvm-kmod/x86/../external-module-compat-comm.h:1724:53: warning:struct static_key_deferred’ declared inside parameter list will not be visible outside of this definition or declaration > static inline void static_key_deferred_flush(struct static_key_deferred *key) > ^~~~~~~~~~~~~~~~~~~ > /home/somlo/FOO/kvm-kmod/x86/../external-module-compat-comm.h: In function ‘static_key_deferred_flush’: > /home/somlo/FOO/kvm-kmod/x86/../external-module-compat-comm.h:1726:25: error: dereferencing pointer to incomplete type ‘struct static_key_deferred’ > flush_delayed_work(&key->work); > ^~ > In file included from :0:0: > /home/somlo/FOO/kvm-kmod/x86/external-module-compat.h: At top level: > /home/somlo/FOO/kvm-kmod/x86/external-module-compat.h:1090:22: fatal error: asm/i387.h: No such file or directory > #include > ^ > compilation terminated. > scripts/Makefile.build:293: recipe for target '/home/somlo/FOO/kvm-kmod/x86/kvm_main.o' failed > make[3]: *** [/home/somlo/FOO/kvm-kmod/x86/kvm_main.o] Error 1 > scripts/Makefile.build:544: recipe for target '/home/somlo/FOO/kvm-kmod/x86' failed > make[2]: *** [/home/somlo/FOO/kvm-kmod/x86] Error 2 > Makefile:1494: recipe for target '_module_/home/somlo/FOO/kvm-kmod' failed > make[1]: *** [_module_/home/somlo/FOO/kvm-kmod] Error 2 > make[1]: Leaving directory '/usr/src/kernels/4.9.10-100.fc24.x86_64' > Makefile:21: recipe for target 'all' failed > make: *** [all] Error 2 > > Any idea where things might be going wrong? > Is F24 (4.9.10-100.fc24.x86_64) too old for this? Let me push a newer version of kvm-kmod. But I only tested it with 4.11. Paolo