From: Logan Gunthorpe <logang@deltatee.com>
To: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>, gregkh@linuxfoundation.org
Cc: axboe@kernel.dk, jlayton@poochiereds.net, bfields@fieldses.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] block, char_dev: Use correct format specifier for unsigned ints
Date: Tue, 6 Feb 2018 10:15:50 -0700 [thread overview]
Message-ID: <2550ca60-5f02-56e7-ff4c-6cd96b20a4d0@deltatee.com> (raw)
In-Reply-To: <151788391701.28069.13145257664735983272.stgit@srivatsa-ubuntu>
On 05/02/18 07:25 PM, Srivatsa S. Bhat wrote:
> From: Srivatsa S. Bhat <srivatsa@csail.mit.edu>
>
> register_blkdev() and __register_chrdev_region() treat the major
> number as an unsigned int. So print it the same way to avoid
> absurd error statements such as:
> "... major requested (-1) is greater than the maximum (511) ..."
> (and also fix off-by-one bugs in the error prints).
>
> While at it, also update the comment describing register_blkdev().
>
> Signed-off-by: Srivatsa S. Bhat <srivatsa@csail.mit.edu>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
next prev parent reply other threads:[~2018-02-06 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 2:25 [PATCH 1/2] char_dev: Fix off-by-one bugs in find_dynamic_major() Srivatsa S. Bhat
2018-02-06 2:25 ` [PATCH 2/2] block, char_dev: Use correct format specifier for unsigned ints Srivatsa S. Bhat
2018-02-06 10:24 ` Greg KH
2018-02-06 19:58 ` Srivatsa S. Bhat
2018-02-06 17:15 ` Logan Gunthorpe [this message]
2018-02-06 17:14 ` [PATCH 1/2] char_dev: Fix off-by-one bugs in find_dynamic_major() Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2550ca60-5f02-56e7-ff4c-6cd96b20a4d0@deltatee.com \
--to=logang@deltatee.com \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@poochiereds.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srivatsa@csail.mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®